From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Barnabás Czémán" <barnabas.czeman@mainlining.org>,
"Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Jonathan Albrieux" <jonathan.albrieux@gmail.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux@mainlining.org,
Danila Tikhonov <danila@jiaxyga.com>
Subject: Re: [PATCH 3/3] iio: magnetometer: ak8975: Add AK09118 support
Date: Tue, 6 Aug 2024 07:22:36 +0200 [thread overview]
Message-ID: <9b01084f-eac3-432e-b221-8a2c35354557@kernel.org> (raw)
In-Reply-To: <20240805-ak09918-v1-3-70837eebd7d8@mainlining.org>
On 05/08/2024 22:31, Barnabás Czémán wrote:
> From: Danila Tikhonov <danila@jiaxyga.com>
>
> Add additional AK09118 to the magnetometer driver which has the same
> register mapping and scaling as the AK09112 device.
>
> Signed-off-by: Danila Tikhonov <danila@jiaxyga.com>
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
...
> };
> MODULE_DEVICE_TABLE(i2c, ak8975_id);
> @@ -1081,6 +1114,8 @@ static const struct of_device_id ak8975_of_match[] = {
> { .compatible = "ak09912", .data = &ak_def_array[AK09912] },
> { .compatible = "asahi-kasei,ak09916", .data = &ak_def_array[AK09916] },
> { .compatible = "ak09916", .data = &ak_def_array[AK09916] },
> + { .compatible = "asahi-kasei,ak09918", .data = &ak_def_array[AK09918] },
> + { .compatible = "ak09918", .data = &ak_def_array[AK09918] },
NAK. That's not a valid compatible.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-08-06 5:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 20:31 [PATCH 0/3] Add support for AK09918 Barnabás Czémán
2024-08-05 20:31 ` [PATCH 1/3] iio: magnetometer: ak8975: Fix reading for ak099xx sensors Barnabás Czémán
2024-08-05 20:31 ` [PATCH 2/3] dt-bindings: iio: imu: magnetometer: Add ak09118 Barnabás Czémán
2024-08-06 5:21 ` Krzysztof Kozlowski
2024-08-05 20:31 ` [PATCH 3/3] iio: magnetometer: ak8975: Add AK09118 support Barnabás Czémán
2024-08-06 5:22 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b01084f-eac3-432e-b221-8a2c35354557@kernel.org \
--to=krzk@kernel.org \
--cc=barnabas.czeman@mainlining.org \
--cc=conor+dt@kernel.org \
--cc=danila@jiaxyga.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=jonathan.albrieux@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@mainlining.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox