From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2575E1A316E for ; Thu, 7 May 2026 15:34:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168091; cv=none; b=lvgRE8pzxYIUiQXZ9y1b4g+QGDu2CY90+iyMWMXo768J/tpZFwpG22mXGgnYE8JtdsgCUdqaXNj6Iy1mFxme0CbOMtGaEQ7ye0pIBwbIVmSp0gDY7lZDQ5Hwm2r7ak2GyFLXKHAg9K1uBT8gcSFSP10+nwqXkNFojrdVJ8VvSPI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168091; c=relaxed/simple; bh=ICugSzsJyECFjzMgcnEwi+FYSUvpOC9JNh/x3lwnJLI=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=nfnO3dexS2D/bikulptveQOXOmFMx5xWBD7zjSFUcYrsAx9RShO1HVZltuzl3FsWxSGpzb4xUxILZzvV8N0FCprIXkcsbsqSx7fgu9Fy5uPkfmbblJUJuZfRZtW5m1fcyN2rCKt2R2lhWUUXhpXyVfZ49tm8bJSHYtxUNbnUVEQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rs4yQwkW; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rs4yQwkW" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so8807745e9.0 for ; Thu, 07 May 2026 08:34:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778168088; x=1778772888; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=HNpNxTDdt1OmLULsDYJhJ1FFpNi+U6Ym7YcH8EiGwkY=; b=rs4yQwkWSaqnXwTMLSBz6t3jTkkqpKQIfZGAh86oalsdKos7ckAIdMiFls13h7X7IJ KYAp26qjaimFQWlJ8TVuYf2th8TTxb6eUWOM7/0dV3DG9Meo9nRHckoCzQ2uD90x/LUa EGzNmMLf6B5yYDE4/AxzAdVQD/qFpKqrmSMKDIyov7AJgxedj72Wv2IgTwvNmwe6BjVO y2OU8BMpVFYMTqs++eVPZmWVx8zssQg0GXQUWb5yMW1fn3bwunIoJtHoW/ugB3xah450 R+RpqQHhV/sXrtywsayHe/rQP8EJSFPVgH8xWgCYKMw1e9T/qo2DZLt4KoS8U0GBvNsp lfKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778168088; x=1778772888; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HNpNxTDdt1OmLULsDYJhJ1FFpNi+U6Ym7YcH8EiGwkY=; b=LkxtkrtRjJgHkZ45CI5bs3AhFBCtZbjhtNkfEqhSZXOFtTEhCD2HB9W+JwJoj+BZFq IEaSPa+hIeMTQzi8n6HZbV/pliR7+zek0dwR1GWz03Nx20MKUNZbyqwCZ0UDHUpKWUYJ z3Bx/E5+0NZPShjmiEEI23AK47ISH/wUCwc5ctkXYiXPpFOILc309PIsFqWIBWovof50 XjZk8fS9e6zxjzBX//i0CbHlEcTIH+H2rONi/kdQUmJhIu6fLvlL3IOblHnDqbInLksr O/ar1OmS3/ub6OfKJWAau9gl4nKq6KoiKpT7Ga89WMx3HJ3oBICyVkitlByDOaVYiJXn Za/A== X-Forwarded-Encrypted: i=1; AFNElJ+LuF2hhuBBkME+TtTARsVCorsvrr2oKVstyJdHQ76bflz8npx9CGxt72lUHiVApt/KiMkN8FJ+mm/ncu0=@vger.kernel.org X-Gm-Message-State: AOJu0YyXTENrQHSKYJLkoUXHPnrEx5UrZbTs1H43FQLdpQTlz9M/rbpd B0+jBQyssS+C2MdltnzOf4/GO/RSb33US4ZYHhR2bMysDTAV9Rg7C3vyUF1gFAVaCXw= X-Gm-Gg: AeBDieulOJWz0oK2YQemCWtr7ajgyQ2OigHz+lNw4g1k4116L/8qDOtvOd7xzw+lAw9 cfasTH1BBOr4xyEj/rZZzOAxVoqNBCce4kxV6LTJoq1OEjTNgjoiws7AUl5THGM9HjkRdl+D8nI u/4WNwSXoDkqimXGwcFNCOzcTORaWDP/05NBcba27qWfknGhqsOwumpTRlmFh996KVRvq6vwI61 e6iiaUSDBysK7kWJQis4yq+6Anl0RMUFY8t9qpEZK3JWeMSHfIBxD7chFxXVakjMapY4ostsvQp CyhDxXj0Nk8XdO8dCrqXjCUDUt2mbJPBvQ/mEVgnlo95mDwyyxK/eM4n5xrtYchURqaGWrw2Mos CLg2bqKIpUVkTk4B9HS+cKKp/h3a1EkNMDHFEjnPpRp/MenR9Kzsq2ZAWcy0RzgTowBaTrLdxgK dk7OFEJJt7rk75qkRZp8PpxGe0wimuBJkYy+cp9E+IC7By6XFIjZ9om9YY24qaJJs6iNFh0PwsR yF8rtNniTqxHKit6rllGm+zbTGN X-Received: by 2002:a05:600c:a30b:b0:489:1c1f:35f9 with SMTP id 5b1f17b1804b1-48e51e1773bmr103146425e9.9.1778168088174; Thu, 07 May 2026 08:34:48 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:6762:47bb:1e06:ff70? ([2a01:e0a:106d:1080:6762:47bb:1e06:ff70]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4505558e213sm22225403f8f.25.2026.05.07.08.34.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 08:34:47 -0700 (PDT) Message-ID: <9b2d61b9-6f7e-49fb-967d-e0858ff782ce@linaro.org> Date: Thu, 7 May 2026 17:34:47 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 01/10] drm/panel/visionox-g2647fb105: Use refcounted allocation in place of devm_kzalloc() To: Albert Esteve , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Michael Tretter , Michael Walle , Dario Binacchi Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260507-drm_panel_init_rm-v1-0-51f448c7c291@redhat.com> <20260507-drm_panel_init_rm-v1-1-51f448c7c291@redhat.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260507-drm_panel_init_rm-v1-1-51f448c7c291@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/7/26 13:52, Albert Esteve wrote: > Move to using the new API devm_drm_panel_alloc() to allocate the > panel. In the call to the new API, avoid using explicit type and use > __typeof() for more type safety. Also deduplicate the prepare_prev_first > assignment that was set both before and after drm_panel_init(). > > Signed-off-by: Albert Esteve > --- > drivers/gpu/drm/panel/panel-visionox-g2647fb105.c | 13 ++++++------- > 1 file changed, 6 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-visionox-g2647fb105.c b/drivers/gpu/drm/panel/panel-visionox-g2647fb105.c > index 413849f7b4dec..d5555a1731575 100644 > --- a/drivers/gpu/drm/panel/panel-visionox-g2647fb105.c > +++ b/drivers/gpu/drm/panel/panel-visionox-g2647fb105.c > @@ -207,9 +207,12 @@ static int visionox_g2647fb105_probe(struct mipi_dsi_device *dsi) > struct visionox_g2647fb105 *ctx; > int ret; > > - ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); > - if (!ctx) > - return -ENOMEM; > + ctx = devm_drm_panel_alloc(dev, __typeof(*ctx), panel, > + &visionox_g2647fb105_panel_funcs, > + DRM_MODE_CONNECTOR_DSI); > + > + if (IS_ERR(ctx)) > + return PTR_ERR(ctx); > > ret = devm_regulator_bulk_get_const(dev, > ARRAY_SIZE(visionox_g2647fb105_supplies), > @@ -233,10 +236,6 @@ static int visionox_g2647fb105_probe(struct mipi_dsi_device *dsi) > > ctx->panel.prepare_prev_first = true; > > - drm_panel_init(&ctx->panel, dev, &visionox_g2647fb105_panel_funcs, > - DRM_MODE_CONNECTOR_DSI); > - ctx->panel.prepare_prev_first = true; > - > ctx->panel.backlight = visionox_g2647fb105_create_backlight(dsi); > if (IS_ERR(ctx->panel.backlight)) > return dev_err_probe(dev, PTR_ERR(ctx->panel.backlight), > Reviewed-by: Neil Armstrong Thanks, Neil