From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EB103368B1; Mon, 16 Mar 2026 16:37:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773679037; cv=none; b=AR4FwV+YfIETHwiaYGonO4tWvCw8GPkjIJrfu30vVkds/2SRLQ2ZqpddYzIiaW15W8dtIvnsvZxjLEGYYyLKdG/vaTdnbQqHGz9JJoUOvWIWXZ4Q7ZXu7iWMWkwQNNikYdaqlkIQ6pjX2uTeUudVSEjjAn2qiBgiRvsET+Gbnr0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773679037; c=relaxed/simple; bh=YMAIPxjG8g4qU2u6NbxETXet6+DAyt53Q6K9A3CX5q8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SWdVA0ExNx11Z/rqz0CDZqTo9IS/spHTjGQi5Tr36XJPWSzHzRtUff5Q/XYbuNvMI+0QmeOCmqF44KAxrYGwdezzA/ytsbxmPOUt9k1bAbMTz6O+gUZwSjQwuA69vdQe9p807MaMNOOjunTnFSCljZc+8SImnpDw6OCb95V/6Uk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de; spf=pass smtp.mailfrom=web.de; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b=JVF3Vx8g; arc=none smtp.client-ip=212.227.17.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=web.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=web.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=web.de header.i=markus.elfring@web.de header.b="JVF3Vx8g" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=web.de; s=s29768273; t=1773679016; x=1774283816; i=markus.elfring@web.de; bh=YMAIPxjG8g4qU2u6NbxETXet6+DAyt53Q6K9A3CX5q8=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=JVF3Vx8gD8zrCtydGtWeboXYI2Qz2FRXRhH8pacxVvpUaT8r5PDZtfwA220c3zaT XjeJvOEvl21Py2ICB6uQiySKh3jv+bvITc2OHjAvZ8GVYcJIEikBkuTL6yIbNm8XE ek3pLmSSppJwUCJ67ctV1I5BuqM8Vo7HTz30ADtz6AWJI73WcVEtHp80BAZcwsIHt bm0Y6ZTPHrs9mGzjRQl5ag4I9jeTcTqUPy4S1Owd6U0rQGaCmOH2gnHOKRQMCL6em nToOZnnEcuK3MKyUsVlLFSjhW5JQbQrNd9Dlbykm2TfR3xDm0yqT8JjMAe2CN07M/ rmeZCf/IhmQm7MFKAQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from client.hidden.invalid by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MKuKF-1wJ1vh2lVV-00QJaI; Mon, 16 Mar 2026 17:36:56 +0100 Message-ID: <9b504811-0998-4879-8ab9-bbcaa423555f@web.de> Date: Mon, 16 Mar 2026 17:36:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: riscv: kvm: fix vector context allocation leak To: Osama Abdelkader , kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org Cc: Albert Ou , Alexandre Ghiti , Anup Patel , Atish Patra , Palmer Dabbelt , Paul Walmsley , LKML References: <20260314223144.154349-1-osama.abdelkader@gmail.com> <19cdcafd-adab-469d-9729-f01e8bcaf543@web.de> Content-Language: en-GB, de-DE From: Markus Elfring In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:4dsqmlkQmVhcN1C6ZRMNRWv42XM2cBsSXGDc/5Ne4+zYSrVBD7l +ROVxErVG8h4OvYw5EOPDjsj1vFJ8t4LvHF60jj+bFYkANjqloUU05OBBNXj7Uavh30Zp6M ydg00WP7EYgPRtAYIOpSDK+rHkEa6B4pVPItAEBLtFWOXZcK0wKxE1os53kAcC9hZzq9WIr 6zY86R3k/Ya9Sd0BTY7Gw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:nLGqwlVCaiw=;Y623OH/x8WSOklSYr26Rar6dIPe GQW4pTWraAy44Qrw9rI16pXvb/aKvEHi6H1/4U34Jw46JWKww5jeqHiTCD9y6IJUbrJSRpZ0b rUI1MboXAY+kQ0KiST3BFl4UrTMpwGC/iuvcq8GKmEDIfPkFKas04L6d3t7JGLJXiboIPltH6 BvbFrrG/g7JWhXu+PxZC3QME4fTL1z13UuzN8kYd/Lc/7Lr3ifGxMROVDdjmVIWP2BDoQS2sJ ndFyhmFjeP1y7Yor9M4f81fALO3tN3ugr9WqoMax/U0f9zoHH4v3N/VUloN/D8OF8E/A+KNlo 7lR/ms1XCh9cA1GoSLEmvaY6tSHuxDGNwVinZREzceNcJpTxFJhfFtCGPYz0F2t6Mz+aj4ePm sP6HKkbdzYa+Wv63UfV76GPOz14HK4kGiKuag1SUEb7iu5g1kjhplvB/sHdx7ESOv6i2R7i3J 0QkfA7TekgXvZ9JUHKLBAHoFllfZ7y9EfmnWiulFpT++s5mm3aZcIwP6eOcGRXAz94zLpBRMr jZMffF3gMrIMbhp4uYn9TII3lf/7HoD420Zp+6DQdsGl4+YMhEn0NOUKnKkTJgcxl/RYpbYTh RgTZVhT058nk2wQmrd3EaweuS0pvoxBIqwddH27WjFF6+io3Oddlt4S0bdGKf19ZVEShP7iIx sQJ5B1FZn4n5heSDSVpFzgpx0gaLwAun8DXLfo99zuq/bPA5xBrEbtUhJGP4SYYskPxQpcqsN iLrS0KnezZyltZcQ1rXsNgKZKfnWlf7T6p7tsRs5qOlkm5SQFzKHRMParSPzcRgkea5g3V36n sMHejXPCKQGg+OpU6Yz/MNRJY0+/yFoYcWuGs3BuoTKA4bgLxzNiPViWXamg3yIA2+hykFkk/ FT/WicHkqunf3/rib7nQxvkLOym9B41zaDB41G5rHxMRYDUpN+DFuR1h6pyK5GUuia1SFecWX pdfBhnkLvLZUh0+kTLLX4Wskr4EqrNFaxSDnteIXrujgxgLpnPupGJnm0PK/KcU1ispIBCS9H LXE+rmm3B9agQAb3C8GlGleRFQem6+AIqFgOM0ycQNdM2awaxz8AYgSLTBCok0fkdJbLlDZzD 1BilWViXrF76jAQW8bqLyNia2ChTmpmDZ0NUHmkblo9nSXIFOfdB0WuHT6C9LK3sir8zXa8rB jIyBKV30F65hw0xlkOAPdhOZ6zkYy8brY8hp3rGgl0Nmm/aEU5xFFf6jf8LeZzq2AaPb7V4wq GoUlrSXNTcGk/hQDt4+bs5+yALfhHtHgWex3HREnbkzNhHWkzS0NqE8mxR60pVJwGf8MMCbmR HCV6LwSAeCmCk7Gw2mDJ/j7NFudp9/CbpqNQ42PNxOkCWEF7MvVqdRDPvaCrkBjbz3qEoVTmf 0B4m0x31HTHiJ4jXH40dKvCGuYB4QphtG8Y08mv5h78WCqFZkCmJCHw6BUmCRUdnSTKD6iR9o 3nXIBs0o/GmJna5hcMBpBo719sZV42XSOQwR5pEAA5rO8Rbnwh0puO3aPBLjZTXEKY+hFbOwk AP+ztNIPXqbm8KC5VTL105+Ozfcgx4pshU3huwWSEIcnO53/HGFH14O9Oh/xuMkGER3+lOzSF QEM7+wLAgaFOH8SaVLl4s79izliZj3bS4rCO0qFwlzZvisQyjHqRY7WARn1kTdUDJuLFoje+d VH5VViXSRg7b1OoSLZqDruTEPvODJOz0Ue6cEzBY4g1Vrdd1fucVpco3QpPiRIr66tfpHnjEb HZt6WoZYiINncdANnYDIkbcMeCeEe3sB3DbhOiAC400UR/sbyVbT65+Bosm0GR2cQP9cIGGgW dGV+N/P0PaApZxD6danwBgAkn9DsBlzKTUr4HESKlZxEqcs/HW5V3eKAvoWHPp0W8GZlYHymx ByT84ifkZCfp/yfnUVI5kaEsLbH7mrYKkybvQW5MMSH8aDR/S8OHZE4FTmsc99ueVjS2q9F3z B+aELEVvwWUnh0d57bhx2DBgot+n2acvVePYkAp7bxaBRH58zdrsb//ourlB6iMJqCuxDQ0W5 lFnMQC3hRb6cx2es2fgbNkKGIvhJLSyhf60NKAW+in/lBWgLEE3KtOp6pNxewbKtpdlCSiV1X tXGt+Cgx5XMarIl1WfCA5j3Chnyf3wE/EQ/NZbyFxg2C5fPPkRcaq1RO+b2U8PN9L20xBBdp9 r3XTwchaJamkx/elm0gSDsiFiTkeVxHrQhkABi652mxet8US8bnvoXPm3OQyfjIeXir1JNDo9 CzfXU6ke1SNd7fBMj9RTC//qWX6Box7g/obV3Bkon+1cmTCh6svwLX41m6z+rrloCa6aJ2hWl r/L7vygqhGp3GCRRn5KnbnK3S63j6JKVg1oH6FeLxYFgIGw2GRTIaNSuH5rR66O98cxQMR3Oq hqavxD/fUnDS6wN4BT1zFpFT7Zqcs3Kax57dpRK16WcCPtcTloIl4VtK2zSUyGKuzXENWvZyV mazFvJbnCeAdIcriUpx70kLBenfEpum46D61zhIaCw7MA3nUAkWKWhQwBMgDtoS5v5984jCeZ UWP7f4Wvecw8PJy5tpPx2YBn+toABpglRAjvT212+qG9t2QM8ChjAxmFZS+NTMefcdM89A0bQ 3zpmjhHKC/DCWYzfVqIBPtoidHP7EN17xXaxu3PCqrJnCEWlCPueDxXTac68yzBQA2Sr1F+iG LKv61shYb4e4UsSDxu9YAXj19T8p7SeaN9AWLn9tQWyKCXeBZ2Um19IiNx8nSJGESnpeMxjml lIJT5yon8qgCEoIgxzgTlRq9x0FL24vZhtzctxEo1/3S4jBC/WGQYuoOqW2K951fmQZ7m1hx0 0lpXoE03KUUb7oE5eS21ueJOlytsz0Ek1TK577DFC1LrPs0Fj8kJZt/cIxsfDPSnC2FZii1aa tCDMz/4ZHlRqptN9yFgYcnM/duyuu6Hc2sSSWnw7CbW2ReNw96L3MCX888NIG1RqjWPZBHIrH 9dgw5/ek9UjxiePOPg8Fn541vww/gGyCyFWRtWfNd2Acaij3lJFIRN0FRjhPGvsjHl0lNNZrl /NpPCBLTL6OIdtGxT3XprQ4/4xhnjUGHed7xLDWLY9X9iA/Eh+AciBWtcZKA63M5GX3XeKn16 uWW8nko91YGq9/V05pQNO/8ix9OF0Z2wkJ0oqIDwMXmCUzZMzpVGj3eGqGrOI5trE6rpGcVDV ba7Xl00b33IaYum/HwzMfbuigs7wFQhAjXXjZAT7XSXibLY9U4QcBHa+HT1i8JaezFfqCHnzY uYwTwn1IhtujvE40Fw4kSTD8jo2Ps8kjLm89gC+byHij+H7vSlW/R11hKDqU0I4+R8AKcDzza 7Kt4UEx4GTWRi3dbFQayczQbxND34BWzKXMJqfQS5jWVHNK9FhTSC63QV7KqH2JgCVpJb+bfK TnW2s7GE1dx3Sg1DK8l70P2TOrvmfRi4JOYMKgrNtDBwqOQb2lbRYaRLgv7PSSFsyABhlM1tw 40JhiNcrHGTB9rtZGc5vmiZ8caGqD1flTuAH2ucoRhuoSXJMHcjTtzXVFTVsltE4/LHYM3fMx Egk1Tyh1L2LEsI9U2wWObI8Lt6YsZ+gbqTGklQ4u3UYspxnDYwdOYZprYqo68vWS+15tkEA7U /hN3gyr8wb5IwK9bkgKcvQxnV6RbgXbqADaoellGKfrGIuzuw4RFhA1g1MIVgqtUhLZ/bUp0h UxCXO7zR8Gh4A+u0cxiZ1qk62089cmbNlxI8zEcmyRXO8XwVPiF0ESMSdTRoODkUgED2u81yA pVkRz3LtXagQnbu3gAee65xemR61cPIC7Z6Aa2wzzCOZlkLaHoYPzt0mnLkZrIECj9npFmUoa k+8u9cI8l3jX7IqeAgtbwobzHLxdE836Yi5c9AKFwKF7e6486eEJZNU09q8msP2essB6YhsQ3 IwrqCAYrgaXkh3FPm7wEXAikP89HmLwTqr8p2Jbe6VcrlcpAByPKw/ObSBFX+WqXRVtWDWE6g cP6VhYrqhqUCjJreO7Z52ywdSkIBFLVDkCVH8hii0OZgVY6OPxn1JPA9r/cjFN8tH8tmgGtOH RnFhqIvA1WJv5mwaO7th5WJsXfO9liwezQhU/QrW9wg6zXw/LGZNJknFxe3QJhFbVGGctXHqA zlRbsW7Mt4jcupwVMKvYcirXp9a8NsKHpjBjjMu4sGyD2JNEJZAlrg1YkNnVWj55+s9ace0Zo BQU430CcYxSl5chvuAYUVr7Azo5AXZUKHOz6b2xdljdT9Www9iFPjlc59UU4VSBBzU4naxBo9 kI2DboKAnJGIXR888oRKcch5c9Vhlec2P12LMfyMbR7HC/ta8SZo21oj0qOyuxX/mtaIrd5Kg 05fUodnxUaADvkzlBMMi+EnIsO1Hwhy3qsl1pOP8F5cwE7i5LWTSZ1RhWbVnGHh16FcW3xWns /+NaHTBYr0wOQ0YbITCc0aMvyYY4wTNv3x84tPsbGUzOLbg4QtW6p3SVHypG7bEWCe58HjdYh kDUSwfaizkW5uRJZEkS+JDsgMDPC9x8ATHcj3M7aL5VxlfBessx3QJ6qNbE4gR7yWJzPun+Yt L/OrqDvmVx3x7marF0LRWd5+rYbZXo4TKC+O/l9wLuhmx1kRreI/k+3siB3cGcboQjSdZLAAh +rbd/sW2Fk/h9znCSIS0EMFg+W1eBl2cdr0OT+V7e6GlykJ+1HG53gUWFtYNmqa79n7Is+UTI eQgBrZxg+kZax5AfQzYaCkkwk9IJYksCted7behhe7+c3pVePz12e1AwyORjlyxVoeymcTg9K 8N91de9Q4esco2yV/aQaGuj+vdpvwLYYege1h/NuT7OFzCZlxCUbs70nwcrieEzZcpV874LeY cVUuJJ556txUDz7NCEyqX6VKBC94BYQumCkdJoyDJIIlfyg4cd/IhBzWjZVdd6LF31R2tVcaP IrGzniSs+c0s2ncqFvNNNFWjD1X2wqdpsT4y759GfOTIR0iG4+9vQt72xtusM2QlgBtPe/n9Y 1oTFMnckm2PiVXodw/fCXz8fdR49VcxOFvZPJIm8CoBz6+5YWbtQial1r/YCBhASr4W4J5qPS gRYxY75HV+SinLnYju0RIStJG9ydnkinr+xyqEdpTyv/l+FYfexV+2CRyJ1pH6xRmdMDNDdDf tnd/FmQrIMvWNHgj/xFTe49KkJ/Tu2hMcE4t5c2MAW1Zjl8iHOVaylFeyIM3SM+qgtdch1QOY 0obgauK7PJVAI/pRtl5xrmfmC9wnz >>> When the second kzalloc (host_context.vector.datap) fails in >>> kvm_riscv_vcpu_alloc_vector_context, the first allocation >>> (guest_context.vector.datap) is leaked. Free it before returning. >> Were any source code analysis tools involved here? >> > No, there were found during manual review. Would be looking for the support of advanced approaches which would make such a =E2=80=9Cinspection=E2=80=9D more convenient? Regards, Markus