From: Martin KaFai Lau <martin.lau@linux.dev>
To: Pu Lehui <pulehui@huaweicloud.com>, Stanislav Fomichev <sdf@google.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Quentin Monnet <quentin@isovalent.com>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Pu Lehui <pulehui@huawei.com>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 1/2] bpf, cgroup: Don't populate prog_attach_flags array when effective query
Date: Fri, 16 Sep 2022 17:03:42 -0700 [thread overview]
Message-ID: <9b66564e-2582-03b2-56f1-8037f8aca886@linux.dev> (raw)
In-Reply-To: <20220914161742.3180731-2-pulehui@huaweicloud.com>
On 9/14/22 9:17 AM, Pu Lehui wrote:
> From: Pu Lehui <pulehui@huawei.com>
>
> Attach flags is only valid for attached progs of this layer cgroup,
> but not for effective progs. For querying with EFFECTIVE flags,
> exporting attach flags does not make sense. so we don't need to
> populate prog_attach_flags array when effective query.
prog_attach_flags has been added to 6.0 which is in rc5. It is still
doable (and cleaner) to reject prog_attach_flags when it is an
effective_query. This should be done regardless of 'type ==
BPF_LSM_CGROUP' or not. Something like:
if (effective_query && prog_attach_flags)
return -EINVAL;
Otherwise, the whole prog_attach_flags needs to be set to 0 during
effective_query. Please target the change to the bpf tree instead of
bpf-next such that this uapi bit can be fixed before 6.0.
Also, the effective_query issue is not limited to the prog_attach_flags?
For the older uattr->query.attach_flags, it should be set to 0 also when
it is an effective_query, right?
next prev parent reply other threads:[~2022-09-17 0:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 16:17 [PATCH bpf-next v3 0/2] Fix wrong cgroup attach flags being assigned to effective progs Pu Lehui
2022-09-14 16:17 ` [PATCH bpf-next v3 1/2] bpf, cgroup: Don't populate prog_attach_flags array when effective query Pu Lehui
2022-09-17 0:03 ` Martin KaFai Lau [this message]
2022-09-19 13:32 ` Pu Lehui
2022-09-19 17:28 ` Martin KaFai Lau
2022-09-14 16:17 ` [PATCH bpf-next v3 2/2] bpftool: Fix wrong cgroup attach flags being assigned to effective progs Pu Lehui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b66564e-2582-03b2-56f1-8037f8aca886@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pulehui@huawei.com \
--cc=pulehui@huaweicloud.com \
--cc=quentin@isovalent.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox