From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: quic_bjorande@quicinc.com, Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Johan Hovold <johan@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc8280xp-pmics: Define adc for temp-alarms
Date: Mon, 12 Feb 2024 12:08:43 +0100 [thread overview]
Message-ID: <9baba05e-6000-4697-ae7e-e423c392f9eb@linaro.org> (raw)
In-Reply-To: <20240210-sc8280xp-pmic-thermal-v1-2-a1c215a17d10@quicinc.com>
On 11.02.2024 05:42, Bjorn Andersson via B4 Relay wrote:
> From: Bjorn Andersson <quic_bjorande@quicinc.com>
>
> sc8280xp-pmics define the two thermal zones "pm8280-1-thermal" and
> "pm8280-2-thermal", but the related temp-alarm instances are not tied to
> any adc channels, and as such continuously report the bogus temperature
> of 37C.
>
> After previously defining these adc channels across all boards using
> sc8280xp-pmics.dtsi, we can now add these references.
>
> This does however mean that we have a non-disabled node referencing
> default-disabled nodes, requiring each board to enable the pmk8280_vadc.
> Avoid this by marking pmk8280_vadc okay.
Thanks for addressing my P1 review comments in a way that indicates time
travel has been achieved ;)
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
next prev parent reply other threads:[~2024-02-12 11:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 4:41 [PATCH 0/2] arm64: dts: qcom: sc8280xp: Make pmic thermal-zones report temperature Bjorn Andersson via B4 Relay
2024-02-11 4:41 ` [PATCH 1/2] arm64: dts: qcom: sc8280xp-crd: Add PMIC die-temp vadc channels Bjorn Andersson via B4 Relay
2024-02-12 11:06 ` Konrad Dybcio
2024-02-11 4:42 ` [PATCH 2/2] arm64: dts: qcom: sc8280xp-pmics: Define adc for temp-alarms Bjorn Andersson via B4 Relay
2024-02-12 11:08 ` Konrad Dybcio [this message]
2024-02-14 17:57 ` [PATCH 0/2] arm64: dts: qcom: sc8280xp: Make pmic thermal-zones report temperature Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9baba05e-6000-4697-ae7e-e423c392f9eb@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johan@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_bjorande@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox