From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FC84261581 for ; Mon, 13 Oct 2025 11:44:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760355884; cv=none; b=gI/4kruC7IsdKr7lYkxsJ3ATNWR2iJ2UsjtmYeVmN8CuUBuxmNElXaKLGVeQAk/6D5csQ4ZlnnV48+12dSInCeP3VIiYool5/9/cNZmRgpTlt2uu/UgU8skWz7M5wMg2m795Lfrk37yD49zWyJjoDcr89tfJZFfsT3Srsq0rjr8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760355884; c=relaxed/simple; bh=m+468Bkpx6SzNqN/4WXzwZci+NKwPHmCNWkdu04s/WI=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=rt82dD3EDiTqgSanPK4NkRPeWSPVd5g84DouHz1SiWI7L6D564e1Jro8hq7iUifdmZ7fv1un6YzjMD8RSbF1LyWUsgDCZotfJjxAzcIb5albm3gwfYbxtY64vJQh2UgE9GfowU/7OQizNAxPD2mi8/9esEBIXGEmmWx7tSICyO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nBzXD7Z3; arc=none smtp.client-ip=209.85.167.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nBzXD7Z3" Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-578ecc56235so3508123e87.0 for ; Mon, 13 Oct 2025 04:44:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760355880; x=1760960680; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=1K17b/K8yQXfwqlp4oNmjpZOU5mgfldRYoFZRQe1+Os=; b=nBzXD7Z3pdwY9D7IpyuoujXnUAyIh1t5q+vtrs8Ow2m+kBQj6Aj8DXR2t51Du40O/O yU2w3pcQg+P3/eQNDIJgHLKMYf6LGcArFHgIm6CzFVrBoPSp8a8o0R6+QSFFwsdc65Vh UaHcl2TlFPmeHuf/ZhS4UM7ByvnYSSR+rpemi8zeOiIaVfwD9eyUq7yopjVOBSd6NvVC BuQnMn/IzeDGdWQxNOFv+4GikiyO0B0UCq/fZ4VItfOCbw+AJXbIZGjhvqM3mOoRvbs7 HBMgx3EHu+1mNfiQYoI3kscRCJKqCJjDXyooozdQvFQ5xzoM27vTocJ/st7UtxqkOG3n R79A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760355880; x=1760960680; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=1K17b/K8yQXfwqlp4oNmjpZOU5mgfldRYoFZRQe1+Os=; b=XAY37xPqfMNh3AQ+2W200yULMGYbdNNZFzuT6XHq3rPgDqNqJdBqA+pVGg3dqd06/1 GVFgc/Y3iaqYh+1OVPa01PoTkyKfUEhXTsDU+q6xYvjk2Mf7l8dkuy/7PC45LK+zQEzp jM4dbqkdPoqm1C2XJkoYZj+axIqJ9yxhtCRm4ee0CinWfqoT0+TQk2wheFiQURT4prEH 3CCdonmAzErLc6kZ579j5LK7wFWLcvjkKo2mfRUyK0FqmyT9mYArKuWcWs1QMElutnJ7 TdzEP/bE/5GiToqt7TcMH/XLD4WWfzuOapozjM/bEkSTSWQiI5aKEuwTPeRKNQrYAYz3 5jHQ== X-Forwarded-Encrypted: i=1; AJvYcCWb8tevImaURQGwP6oBUFjjLM7EAivQYEe7KK+/5VlUnqhGezgs59g0PaYOuGGlMheKeN735fnZnUkC0IM=@vger.kernel.org X-Gm-Message-State: AOJu0YwUYlk2l58pLWqofKJ1nTkux9bcIsU1aiZqRGpGO5mJByMA1XCq M7PFU1Rgs+Fx2yCHFy/46JXz6UNj8KvDTeOsv1C7RPiSfMkQQXOrQEe/yEw2vxCmOMM= X-Gm-Gg: ASbGncuho6mSjJE7XfUXMoq/2ob0hebGn4w+rrHgiAQei/aiGyerfRtQUwyK9sfeve4 CVNw1pmfWmk1a3DPrMrY8BGtmvSx2go/nb63Z2WfRZNBfTlvq7Mz84RAZp8b+MNq7nLljC6GRiy 6efMr2Ch2DcLiFUvY22z7i2woDtuoW79eFesbawxfmeWoKjCPILmfGbUUCd8iRLtu7eCSYug1Dg Mie/5Chd/O2E318Zoj8RzkfaZuE1BCgDnjVAIBt1uNiI9OQqXNwpWS5jMksYKWQkgTtZDjxpWKW Z/+xcc57ffGHR4jYP4OYBxmln2NvZT4VyJuAzayWIC7/I7nCZPQAhpugAkz20C4KRCPy7qhxtOW fWooBgw6D7a5UstXUh3tAdpNevc7QvM9AoSXokVzKWl61 X-Google-Smtp-Source: AGHT+IE3d16akBxeLLNasuVPZAcPS6yQwFuxf/4sTLdfKlAN6I/lYxBnzcpDd444DNztoAVGRjcn2g== X-Received: by 2002:a05:6512:682:b0:57e:3d46:d6bc with SMTP id 2adb3069b0e04-5906d773518mr4914882e87.1.1760355880260; Mon, 13 Oct 2025 04:44:40 -0700 (PDT) Received: from [192.168.1.161] ([81.200.23.195]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-590881e4f26sm4063733e87.9.2025.10.13.04.44.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Oct 2025 04:44:39 -0700 (PDT) Message-ID: <9badd4e53ddb6166d0aa196da978bd70f61642de.camel@gmail.com> Subject: Re: [PATCH 2/3] hwmon: (peci/dimmtemp) add Intel Emerald Rapids platform support From: Ivan Mikhaylov To: Paul Menzel Cc: Iwona Winiarska , Guenter Roeck , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org Date: Mon, 13 Oct 2025 14:44:34 +0300 In-Reply-To: <0ede72a9-4555-4e4d-959d-3a505b6598ee@molgen.mpg.de> References: <20251006215321.5036-1-fr0st61te@gmail.com> <20251006215321.5036-3-fr0st61te@gmail.com> <0ede72a9-4555-4e4d-959d-3a505b6598ee@molgen.mpg.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2025-10-07 at 10:26 +0200, Paul Menzel wrote: > Dear Ivan, >=20 >=20 > Thank you for your patch. >=20 > Am 06.10.25 um 23:53 schrieb Ivan Mikhaylov: > > Extend the functionality of hwmon (peci/dimmtemp) for Emerald > > Rapids > > platform. > >=20 > > The patch has been tested on a 5S system with 16 DIMMs installed. >=20 > What is 5S? 5 sockets? (Probably not.) Paul, thank your for review and sorry for late reply. 5S - Intel 5 Series/5th Gen >=20 > > Verified read of DIMM temperature thresholds & temperature. >=20 > Also paste the output? >=20 root@bmc:/sys/bus/peci# ls -l devices/0-30/ lrwxrwxrwx 1 root root 0 Oct 13 10:51 driver -> ../../../../../../../bus/peci/drivers/peci-cpu drwxr-xr-x 4 root root 0 Oct 13 10:51 peci_cpu.cputemp.emr.48 drwxr-xr-x 4 root root 0 Oct 13 10:51 peci_cpu.dimmtemp.emr.48 drwxr-xr-x 2 root root 0 Oct 13 10:51 power --w------- 1 root root 4096 Oct 13 10:51 remove lrwxrwxrwx 1 root root 0 Oct 13 10:51 subsystem -> ../../../../../../../bus/peci -rw-r--r-- 1 root root 4096 Oct 13 10:51 uevent root@bmc:/sys/bus/peci# ls -l devices/0-31/ lrwxrwxrwx 1 root root 0 Oct 13 10:51 driver -> ../../../../../../../bus/peci/drivers/peci-cpu drwxr-xr-x 4 root root 0 Oct 13 10:51 peci_cpu.cputemp.emr.49 drwxr-xr-x 4 root root 0 Oct 13 10:51 peci_cpu.dimmtemp.emr.49 drwxr-xr-x 2 root root 0 Oct 13 10:51 power --w------- 1 root root 4096 Oct 13 10:51 remove lrwxrwxrwx 1 root root 0 Oct 13 10:51 subsystem -> ../../../../../../../bus/peci -rw-r--r-- 1 root root 4096 Oct 13 10:51 uevent root@bmc:/sys/class/hwmon/hwmon3# ls device of_node subsystem temp11_input temp11_max =20 temp13_input temp13_max temp15_input temp15_max temp1_input =20 temp1_max temp3_input temp3_max temp5_input temp5_max =20 temp7_input temp7_max temp9_input temp9_max name power temp11_crit temp11_label temp13_crit =20 temp13_label temp15_crit temp15_label temp1_crit temp1_label =20 temp3_crit temp3_label temp5_crit temp5_label temp7_crit =20 temp7_label temp9_crit temp9_label uevent root@bmc:/sys/class/hwmon/hwmon5# ls device of_node subsystem temp11_input temp11_max =20 temp13_input temp13_max temp15_input temp15_max temp1_input =20 temp1_max temp3_input temp3_max temp5_input temp5_max =20 temp7_input temp7_max temp9_input temp9_max name power temp11_crit temp11_label temp13_crit =20 temp13_label temp15_crit temp15_label temp1_crit temp1_label =20 temp3_crit temp3_label temp5_crit temp5_label temp7_crit =20 temp7_label temp9_crit temp9_label uevent root@bmc:/sys/class/hwmon/hwmon3# cat temp* 95000 35000 DIMM F1 93000 95000 35000 DIMM G1 93000 95000 34000 DIMM H1 93000 95000 35000 DIMM A1 93000 95000 36000 DIMM B1 93000 95000 36000 DIMM C1 93000 95000 36000 DIMM D1 93000 95000 36000 root@bmc:/sys/class/hwmon/hwmon5# cat temp* 95000 34000 DIMM F1 93000 95000 34000 DIMM G1 93000 95000 35000 DIMM H1 93000 95000 36000 DIMM A1 93000 95000 35000 DIMM B1 93000 95000 35000 DIMM C1 93000 95000 35000 DIMM D1 93000 95000 35000 DIMM E1 93000 Values around ~35 is temp*_input and thresholds as 93,95 for max and crit temepratures plus temp*_label. Guenter, I saw that you already applied other two patches, need I resubmit series with updated info of commit for this one or just this one? >=20