Re: [PATCH 0/2] staging: rtl8192e: Use MSR_LINK_* macros

Greg KH
2024-10-09T09:53:55Z

On Sun, Sep 22, 2024 at 09:01:09PM +0200, Philipp Hortmann wrote:
> On 9/21/24 2:22 PM, Dominik Karol Piątkowski wrote:
> > There were two seemingly not used macros defined in r8192E_hw.h:
> > MSR_LINK_ADHOC and MSR_LINK_MASTER.
> >
> > There is one function explicitly updating MSR (Media Status Register):
> > _rtl92e_update_msr - only MSR_LINK_MASK and MSR_LINK_MANAGED are used
> > there. However, in rtl92e_set_reg, inside HW_VAR_MEDIA_STATUS section,
> > MSR is also updated - covering more than MSR_LINK_MANAGED case.
> >
> > This series makes use of appropriate MSR_LINK_* macros in rtl92e_set_reg
> > and removes duplicated MSR_* macros. While at it, fix camel case variable
> > in rtl92e_set_reg function.
> >
> > Signed-off-by: Dominik Karol Piątkowski <dominik.karol.piatkowski@protonmail.com>
> >
> > Dominik Karol Piątkowski (2):
> > staging: rtl8192e: Use MSR_LINK_* macros
> > staging: rtl8192e: r8192E_dev.c: Rename btMsr variable
> >
> > drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 14 +++++++-------
> > drivers/staging/rtl8192e/rtl8192e/r8192E_hw.h | 6 +-----
> > 2 files changed, 8 insertions(+), 12 deletions(-)
> >
>
> Reviewed-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
>

This driver is now deleted from the tree, sorry.

greg k-h