From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CFD027FB2E for ; Wed, 25 Mar 2026 10:12:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774433547; cv=none; b=kB+NzKR4MeT4bBcBIu+Jm7ueZGBpeIireXt+JBAiN59QC2AUtZW0i5HckssN6TI4H3d65bmWBdJIVddRKX515X/Aikh6R73OA+iuAlKz044d91aG9ku1MnVTEc4GkUe5nA2YS1mtuDJePc0Jdoswu+osF/avrZDvgMrQL07a0mg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774433547; c=relaxed/simple; bh=m56/b3WOzdczHaxO3PWQ3LHZIR79H+h2yCAj5xOJYe0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=MYy6noLmqzsoI3eZw+x5pzpA3ysXjVxQtMj9Zdj/vu/91QXMNSk/RRyEo0ST/XNaspFyNMwuLEYIpbMxx/wCS7I1ZX/hgjuevCsV2u52tQXhwR+bEsI9S+sp/T72TUrbJ+HV33dte03nHUJKjEQaePLJfIrczxZuJf3onh/3ZGo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=avc3bssr; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="avc3bssr" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-483487335c2so52224855e9.2 for ; Wed, 25 Mar 2026 03:12:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774433544; x=1775038344; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=m56/b3WOzdczHaxO3PWQ3LHZIR79H+h2yCAj5xOJYe0=; b=avc3bssreIgFfAmdzrvzIr/Tf0xQ5t5dN+pgfWGhW8TlGyuDhQu385sDwBo9iYv65m F3vBh9M+VfI2ywySrtXISxuUxZnh3t3/MjuVBFbISOx8XRSiVGGS7LIjtzRtmfV/7FNK zcmE+HhMM9YrfKw2eLjAjSABm1cNthihOdV18QgwPNX+lyIKoCXtpnoI52J9UVZvwKyU IwGw+sV3fSDxumuqECvL4rK5LQeKV/oIjZKJ0Q78oGUbECJPJ4aU1RslBFmilm11Pf3M gRWBH4yx4U7cQxAaaMDfuVyjCjFu0sNvzZ8sf6hw/b95Td+l/4QmMZIhQ77aihwMNzUD yN1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774433544; x=1775038344; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=m56/b3WOzdczHaxO3PWQ3LHZIR79H+h2yCAj5xOJYe0=; b=Jjl6H1LVne5REZxFIypeeZ1RzD9BjTTmY97aPSkY5aSJPvDYjf+SkG7CaBpD17EVrP UHtBXw7vDlFq2npZukx3gyYNKjp8n4husIeW1LRaKUuTvVtGJhdJXSgeiUbXM7EUvMrk jj1UJE1cc5SthV62ClPeT9gc3XZJY/xUytCxNdOg8jt2yqaMINTmO1pAfu2w1dYwtV4q Vll2gVJ7EzHwqJN//uQr2GcQuLgXT88G+AH8XXhgvnYOxOYh+EhtfZ9XnHtBGT9LQ/YH 0FuE6hxUqCX2SjYnBW0j3wHtq/7PO09pT0nFzyImfJZWQnDiF8x86rfLEAkA1hH2+92B s6kw== X-Forwarded-Encrypted: i=1; AJvYcCW9h+s0yK3oAlBp+jGPXsITm4JuZEEGYVXO03273NRQRcvoU2CPIOkrsIFel33xH1fD1IQFVwPQkgCA+tw=@vger.kernel.org X-Gm-Message-State: AOJu0YwFxK1mC75mGT1hQ1rk+3JSJV6MuxTk1Mn30fTU6VQdOn5tz5zW 98vK9uS1FS1429Y4RfJ2bAXQ5Gqwb32XCitPWH+J0Z6TcBPlgRMMUwKH X-Gm-Gg: ATEYQzw8OZ64jpJGh/NBjBHXJzfR6qcSeqTKgqB4WVra5AfPZ2KGT+muvWTYo+htPyI o1ze4SelTC/Cc0GeBQHhUsleo68H1Sbt2eac3JAsXIbb304JBYPa/NOk2Im0oY9xHBGTgxsat6K Fj0ixxw04S8cNVYJEuXg1E4AnKNuJ2k3WqrEJXs5KAdIUyVCzfceZKZQNbafxxtJBrMc1JL26sa GTyrLQEeyPz/d/YVCavxKccq5dAOayArLLd4IeAwlYodMHorOibvc86XeBz6y2Pe4kRi6MSBVH2 OrfaUrn6Dis3HhbIJAd4iarnmgYVvmNCq1DlhqZb1fa+l4eXqdZLZFxfOje0gT+JWO/Fpbt1yC7 myKS29SU3srQfDBtCIeq8kaB2MfXi2ncsIB2ZhiVoEGff2opU84RWCApy/sflhs1KSMCr+KiyLX 57pwzJNR+viqHVqMZ7ZkxSlc7e1AOdJoo= X-Received: by 2002:a05:600c:5296:b0:487:13d:4e77 with SMTP id 5b1f17b1804b1-48716067315mr43725525e9.27.1774433543852; Wed, 25 Mar 2026 03:12:23 -0700 (PDT) Received: from [192.168.1.187] ([148.63.225.166]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4871739609csm16267605e9.33.2026.03.25.03.12.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2026 03:12:23 -0700 (PDT) Message-ID: <9bd364de66e86c8f94e410cc926775997f85b070.camel@gmail.com> Subject: Re: [PATCH v3 2/2] iio: dac: ad5706r: Add support for AD5706R DAC From: Nuno =?ISO-8859-1?Q?S=E1?= To: "Torreno, Alexis Czezar" , Andy Shevchenko Cc: Lars-Peter Clausen , "Hennerich, Michael" , Jonathan Cameron , David Lechner , "Sa, Nuno" , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Wed, 25 Mar 2026 10:13:10 +0000 In-Reply-To: References: <20260318-dev_ad5706r-v3-0-5d078f41e988@analog.com> <20260318-dev_ad5706r-v3-2-5d078f41e988@analog.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-03-25 at 01:07 +0000, Torreno, Alexis Czezar wrote: > > > > > Changes since v1: > > > > > =C2=A0 - Removed PWM, GPIO, clock generator, debugfs, regmap, > > > > > IIO_BUFFER > > > >=20 > > > > Why was regmap removed?! Was it not used? > > >=20 > > > As far as I understand it, regmap also gives access to debugfs. When = I > > > removed debugfs I also added regmap as removed. > >=20 > > Not only debugfs, and it's unrelated to the any custom debugfs interfac= es in > > the driver, it's just a feature out-of-the-box of regmap. > >=20 > > > For the spi write/read I am not using regmap as the device has some > > > features that I think regmap_read/write couldn't support. Namely the > > > variable data width, as the device only accepts exact amount of clock > > > cycles. Future patches will also add variable SPI speed. > >=20 > > We have a lot of flexibility in regmap core. Do you think it can be imp= roved / > > extended to cover the cases like yours? > >=20 >=20 > To neatly summarize, my needs are: (in future patches) > 1. SPI read/write can have different frequencies and runtime changeable > 2. SPI data bits needs to be exactly 8bits or 16bits depending on registe= r width > 3. DAC Device reads SPI command bits [14:12] for communication, not just = chip select >=20 > For regmap to be used > 1. regmap_config would need new read_speed and write_speed entries. > 2. val_bits must now be changeable depending on the need. > 3. I think the read/write_flag_mask can do this. >=20 Do not forget you can just implement your custom regmap_bus which also open= s new "doors". - Nuno S=C3=A1