public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tariq Toukan <ttoukan.linux@gmail.com>
To: Huilong Deng <denghuilong@cdjrlc.com>, yishaih@nvidia.com
Cc: linux-rdma@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mlx4_core: Remove trailing semicolon in macros
Date: Sun, 20 Jun 2021 18:06:53 +0300	[thread overview]
Message-ID: <9bdb1fd3-8a48-a9aa-8775-7e07dac8d56c@gmail.com> (raw)
In-Reply-To: <20210620143624.51150-1-denghuilong@cdjrlc.com>



On 6/20/2021 5:36 PM, Huilong Deng wrote:
> Macros should not use a trailing semicolon.
> 
> Signed-off-by: Huilong Deng <denghuilong@cdjrlc.com>
> ---
>   include/linux/mlx4/doorbell.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/mlx4/doorbell.h b/include/linux/mlx4/doorbell.h
> index f31bba270aa2..e3ecaa4f00fa 100644
> --- a/include/linux/mlx4/doorbell.h
> +++ b/include/linux/mlx4/doorbell.h
> @@ -66,7 +66,7 @@ static inline void mlx4_write64(__be32 val[2], void __iomem *dest,
>    * MMIO writes.
>    */
>   
> -#define MLX4_DECLARE_DOORBELL_LOCK(name) spinlock_t name;
> +#define MLX4_DECLARE_DOORBELL_LOCK(name) spinlock_t name
>   #define MLX4_INIT_DOORBELL_LOCK(ptr)     spin_lock_init(ptr)
>   #define MLX4_GET_DOORBELL_LOCK(ptr)      (ptr)
>   
> 

Reviewed-by: Tariq Toukan <tariqt@nvidia.com>

Thanks,
Tariq

           reply	other threads:[~2021-06-20 15:07 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20210620143624.51150-1-denghuilong@cdjrlc.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9bdb1fd3-8a48-a9aa-8775-7e07dac8d56c@gmail.com \
    --to=ttoukan.linux@gmail.com \
    --cc=denghuilong@cdjrlc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox