* Re: [PATCH] mlx4_core: Remove trailing semicolon in macros
[not found] <20210620143624.51150-1-denghuilong@cdjrlc.com>
@ 2021-06-20 15:06 ` Tariq Toukan
0 siblings, 0 replies; only message in thread
From: Tariq Toukan @ 2021-06-20 15:06 UTC (permalink / raw)
To: Huilong Deng, yishaih; +Cc: linux-rdma, netdev, linux-kernel
On 6/20/2021 5:36 PM, Huilong Deng wrote:
> Macros should not use a trailing semicolon.
>
> Signed-off-by: Huilong Deng <denghuilong@cdjrlc.com>
> ---
> include/linux/mlx4/doorbell.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/mlx4/doorbell.h b/include/linux/mlx4/doorbell.h
> index f31bba270aa2..e3ecaa4f00fa 100644
> --- a/include/linux/mlx4/doorbell.h
> +++ b/include/linux/mlx4/doorbell.h
> @@ -66,7 +66,7 @@ static inline void mlx4_write64(__be32 val[2], void __iomem *dest,
> * MMIO writes.
> */
>
> -#define MLX4_DECLARE_DOORBELL_LOCK(name) spinlock_t name;
> +#define MLX4_DECLARE_DOORBELL_LOCK(name) spinlock_t name
> #define MLX4_INIT_DOORBELL_LOCK(ptr) spin_lock_init(ptr)
> #define MLX4_GET_DOORBELL_LOCK(ptr) (ptr)
>
>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Thanks,
Tariq
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-20 15:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210620143624.51150-1-denghuilong@cdjrlc.com>
2021-06-20 15:06 ` [PATCH] mlx4_core: Remove trailing semicolon in macros Tariq Toukan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox