From: Neil Armstrong <narmstrong@baylibre.com>
To: Yejune Deng <yejune.deng@gmail.com>,
kishon@ti.com, vkoul@kernel.org, khilman@baylibre.com,
jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
p.zabel@pengutronix.de
Cc: lorenzo.pieralisi@arm.com, repk@triplefau.lt,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH] phy: amlogic: Replace devm_reset_control_array_get()
Date: Tue, 17 Nov 2020 09:34:51 +0100 [thread overview]
Message-ID: <9be419cc-ffbf-c260-e804-bc29887781ed@baylibre.com> (raw)
In-Reply-To: <1605592689-10108-1-git-send-email-yejune.deng@gmail.com>
On 17/11/2020 06:58, Yejune Deng wrote:
> devm_reset_control_array_get_exclusive() looks more readable
>
> Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
> ---
> drivers/phy/amlogic/phy-meson-axg-pcie.c | 2 +-
> drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c | 2 +-
> drivers/soc/amlogic/meson-ee-pwrc.c | 3 +--
> drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 2 +-
> 4 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/phy/amlogic/phy-meson-axg-pcie.c b/drivers/phy/amlogic/phy-meson-axg-pcie.c
> index 377ed0d..3204f02 100644
> --- a/drivers/phy/amlogic/phy-meson-axg-pcie.c
> +++ b/drivers/phy/amlogic/phy-meson-axg-pcie.c
> @@ -155,7 +155,7 @@ static int phy_axg_pcie_probe(struct platform_device *pdev)
> if (IS_ERR(priv->regmap))
> return PTR_ERR(priv->regmap);
>
> - priv->reset = devm_reset_control_array_get(dev, false, false);
> + priv->reset = devm_reset_control_array_get_exclusive(dev);
> if (IS_ERR(priv->reset))
> return PTR_ERR(priv->reset);
>
> diff --git a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> index 08e3227..bab6345 100644
> --- a/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> +++ b/drivers/phy/amlogic/phy-meson-g12a-usb3-pcie.c
> @@ -418,7 +418,7 @@ static int phy_g12a_usb3_pcie_probe(struct platform_device *pdev)
> if (ret)
> goto err_disable_clk_ref;
>
> - priv->reset = devm_reset_control_array_get(dev, false, false);
> + priv->reset = devm_reset_control_array_get_exclusive(dev);
> if (IS_ERR(priv->reset))
> return PTR_ERR(priv->reset);
>
> diff --git a/drivers/soc/amlogic/meson-ee-pwrc.c b/drivers/soc/amlogic/meson-ee-pwrc.c
> index ed7d2fb..3a879a4 100644
> --- a/drivers/soc/amlogic/meson-ee-pwrc.c
> +++ b/drivers/soc/amlogic/meson-ee-pwrc.c
> @@ -413,8 +413,7 @@ static int meson_ee_pwrc_init_domain(struct platform_device *pdev,
> dev_warn(&pdev->dev, "Invalid resets count %d for domain %s\n",
> count, dom->desc.name);
>
> - dom->rstc = devm_reset_control_array_get(&pdev->dev, false,
> - false);
> + dom->rstc = devm_reset_control_array_get_exclusive(&pdev->dev);
> if (IS_ERR(dom->rstc))
> return PTR_ERR(dom->rstc);
> }
> diff --git a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
> index 8790627..b4615b2 100644
> --- a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
> +++ b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
> @@ -304,7 +304,7 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev)
> return PTR_ERR(regmap_hhi);
> }
>
> - rstc = devm_reset_control_array_get(&pdev->dev, false, false);
> + rstc = devm_reset_control_array_get_exclusive(&pdev->dev);
> if (IS_ERR(rstc)) {
> if (PTR_ERR(rstc) != -EPROBE_DEFER)
> dev_err(&pdev->dev, "failed to get reset lines\n");
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
next prev parent reply other threads:[~2020-11-17 8:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 5:58 [PATCH] phy: amlogic: Replace devm_reset_control_array_get() Yejune Deng
2020-11-17 8:34 ` Neil Armstrong [this message]
2020-11-17 22:52 ` Martin Blumenstingl
-- strict thread matches above, loose matches on Subject: below --
2020-11-18 2:36 [PATCH] phy: amlogic: replace devm_reset_control_array_get() Yejune Deng
2020-11-18 14:55 ` Philipp Zabel
2020-11-22 21:55 ` Martin Blumenstingl
2020-11-30 11:02 ` Vinod Koul
2020-11-03 4:37 [PATCH] phy: amlogic: Replace devm_reset_control_array_get() Yejune Deng
2020-11-03 9:04 ` Remi Pommarel
2020-11-08 22:13 ` Martin Blumenstingl
2020-11-16 7:24 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9be419cc-ffbf-c260-e804-bc29887781ed@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=p.zabel@pengutronix.de \
--cc=repk@triplefau.lt \
--cc=vkoul@kernel.org \
--cc=yejune.deng@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).