From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF21C363086 for ; Tue, 5 May 2026 14:21:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777990879; cv=none; b=B/bXbO34bjy9k+1r/4bziBCy06Utt+I8DDJ7Gjd0GAnZaRdQvUEsr2zB+KUBtDyPDxCzxHiVjjYt7bhdxqpPGmxQgHxjSWsQibD1CjXKzKWeRI+37w4UlsOF0odpZC+ERjhUOdtSL0W7qTZUSMOiA0EIScMENt5ONbBFKLfE+jY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777990879; c=relaxed/simple; bh=wnA2GB9nP8IP98fTklv77efne0MeL9i6WbrGoo3QIb8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=O3DKGMzqtCzqwad+HApD4YxrApj2qjy3W67FkTFhqoiv/ODVtrJ9R6IM52L3XDup0SGzW+uTSlw4DJGy4j5zGpdNsHD7oGhq3TEQq3wVyUJD9NoEpyzGyyevZSJzMnj2eZVqcbcwi+i0GTdJA6gQDGxNRUExVTm8XkJc6t3MzCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YPcTthyv; arc=none smtp.client-ip=198.175.65.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YPcTthyv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777990878; x=1809526878; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=wnA2GB9nP8IP98fTklv77efne0MeL9i6WbrGoo3QIb8=; b=YPcTthyvbQWW2+0d5K2GcZluYGx7+LoFuMyfOVXAL9jtjC1NtZ3pa/OZ OSm/Kqh6+UqpPFoMijPMHHnhUAx1b2XHpX7DXSZAM+pAE5eai7s0mH51Z YfQePVcEe1cPWDgFzoeH+UpKIrw0vrKnrED8vIeFGTV80QVSW+spoEzQJ OvfZVJJRteDkscdzVUm7rWngOyOe6hV8PyWlVAzc3DRA+n8bZg2CtEHjN i3kuw7lPOJYyAzgtb4NV+g5MokOwnYTIOfQDV26aYW8iubdzSoWDUhMIi 8ZIJapRnlymSxkruBIk06IlFdm7tjPNect0QHWcd3m5scty2dYgGWJS5C A==; X-CSE-ConnectionGUID: Tcvq5djfSyaufGzZ9ggP2w== X-CSE-MsgGUID: 4IvvObX1TQyMFHk1sO7n0A== X-IronPort-AV: E=McAfee;i="6800,10657,11777"; a="89167369" X-IronPort-AV: E=Sophos;i="6.23,217,1770624000"; d="scan'208";a="89167369" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2026 07:21:17 -0700 X-CSE-ConnectionGUID: rWBFTBIQRFSYGx7kSHKDqg== X-CSE-MsgGUID: 8xQeJEnRRiyyURmmUMCr6A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,217,1770624000"; d="scan'208";a="235907361" Received: from amilburn-desk.amilburn-desk (HELO localhost) ([10.245.244.55]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 May 2026 07:21:15 -0700 From: Jani Nikula To: Julian Braha , joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, airlied@gmail.com, simona@ffwll.ch Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Julian Braha Subject: Re: [PATCH] drm/i915: replace select with dependency for visible DEBUG_OBJECTS In-Reply-To: <20260502191932.4491-1-julianbraha@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260502191932.4491-1-julianbraha@gmail.com> Date: Tue, 05 May 2026 17:21:12 +0300 Message-ID: <9bf23cfc4489e45fa57e0d5cfd50b02aa811e6c5@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Sat, 02 May 2026, Julian Braha wrote: > DRM_I915_SW_FENCE_DEBUG_OBJECTS currently selects DEBUG_OBJECTS even though > DEBUG_OBJECTS is visible to users. Other config options use 'depends on' > for DEBUG_OBJECTS, so let's do the same here. > > This select-visible Kconfig misusage was detected by Kconfirm, a static > analysis tool for Kconfig. > > Signed-off-by: Julian Braha Thanks for the patch, pushed to drm-intel-next. BR, Jani. > --- > drivers/gpu/drm/i915/Kconfig.debug | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug > index 52a3a59b4ba2..028a2c97361d 100644 > --- a/drivers/gpu/drm/i915/Kconfig.debug > +++ b/drivers/gpu/drm/i915/Kconfig.debug > @@ -153,7 +153,7 @@ config DRM_I915_TRACE_GTT > config DRM_I915_SW_FENCE_DEBUG_OBJECTS > bool "Enable additional driver debugging for fence objects" > depends on DRM_I915 > - select DEBUG_OBJECTS > + depends on DEBUG_OBJECTS > default n > help > Choose this option to turn on extra driver debugging that may affect -- Jani Nikula, Intel