From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>,
Mudit Sharma <muditsharma.info@gmail.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: gts: Simplify available scale table build
Date: Sun, 22 Dec 2024 11:24:23 +0200 [thread overview]
Message-ID: <9c07b71a-160f-4336-8a8d-cad7003e4b68@gmail.com> (raw)
In-Reply-To: <20241220192118.3e9ba7f9@jic23-huawei>
On 20/12/2024 21:21, Jonathan Cameron wrote:
> On Mon, 16 Dec 2024 10:56:37 +0200
> Matti Vaittinen <mazziesaccount@gmail.com> wrote:
>
>> Make available scale building more clear. This hurts the performance
>> quite a bit by looping throgh the scales many times instead of doing
>> everything in one loop. It however simplifies logic by:
>> - decoupling the gain and scale allocations & computations
>> - keeping the temporary 'per_time_gains' table inside the
>> per_time_scales computation function.
>> - separating building the 'all scales' table in own function and doing
>> it based on the already computed per-time scales.
>>
>> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> Looks good to me, but I want to leave it on list a while before applying.
> Ideal if it gets some tested-by or other tags before I pick it up.
> As always, this is fiddly code, so the more eyes the better!
Please, let it wait until the Christmas has passed. I got information we
might be getting some testing before the year changes :)
Yours,
-- Matti
next prev parent reply other threads:[~2024-12-22 9:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 8:56 [PATCH v2] iio: gts: Simplify available scale table build Matti Vaittinen
2024-12-20 19:21 ` Jonathan Cameron
2024-12-22 9:24 ` Matti Vaittinen [this message]
2025-01-10 14:26 ` Matti Vaittinen
2025-01-11 4:17 ` Subhajit Ghosh
2025-01-11 12:42 ` Jonathan Cameron
2025-01-18 17:17 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c07b71a-160f-4336-8a8d-cad7003e4b68@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=muditsharma.info@gmail.com \
--cc=subhajit.ghosh@tweaklogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox