From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Eugen Hristev <eugen.hristev@collabora.com>,
tiffany.lin@mediatek.com, andrew-ct.chen@mediatek.com,
matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
kernel@collabora.com, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v3 2/6] dt-bindings: media: mtk-vcodec-encoder: fix non-vp8 clock name
Date: Tue, 2 Jan 2024 10:13:54 +0100 [thread overview]
Message-ID: <9c2c42f6-e10a-4ff1-89c7-8635b8f8b73e@collabora.com> (raw)
In-Reply-To: <20231228113245.174706-3-eugen.hristev@collabora.com>
Il 28/12/23 12:32, Eugen Hristev ha scritto:
> Looking at the binding it makes sense that the `-vp8` compatible has
> the `venc_lt_sel` while the other bindings have the `venc_sel` as name for
> the clock.
> This was also mentioned in the txt version of the binding before the
> conversion:
> `
> clock-names: avc encoder must contain "venc_sel", vp8 encoder must
> contain "venc_lt_sel", decoder must contain "vcodecpll", "univpll_d2",
> `
>
> So it is easier to check for compatible that includes vp8, since that's
> just one, to have the requirement for the clock name property as
> `venc_lt_sel`, rather than for all the others, some of which are missing,
> thus for them, the requirement is wrongly `venc_lt_sel`.
>
> Reordered the if/then/else to match `-vp8` and have all the rest of
> the compatibles using the other clock name (`venc_sel`).
>
> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2024-01-02 9:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 11:32 [PATCH v3 0/6] video encoder on mt8186 Eugen Hristev
2023-12-28 11:32 ` [PATCH v3 1/6] media: mediatek: vcodec: fix possible unbalanced PM counter Eugen Hristev
2023-12-28 11:32 ` [PATCH v3 2/6] dt-bindings: media: mtk-vcodec-encoder: fix non-vp8 clock name Eugen Hristev
2024-01-02 9:13 ` AngeloGioacchino Del Regno [this message]
2023-12-28 11:32 ` [PATCH v3 3/6] arm64: dts: mediatek: mt8192: fix vencoder " Eugen Hristev
2024-01-02 9:13 ` AngeloGioacchino Del Regno
2023-12-28 11:32 ` [PATCH v3 4/6] dt-bindings: media: mtk-vcodec-encoder: add compatible for mt8186 Eugen Hristev
2024-01-02 9:14 ` AngeloGioacchino Del Regno
2023-12-28 11:32 ` [PATCH v3 5/6] arm64: dts: mediatek: mt8186: fix VENC power domain clocks Eugen Hristev
2024-01-02 9:14 ` AngeloGioacchino Del Regno
2023-12-28 11:32 ` [PATCH v3 6/6] arm64: dts: mediatek: mt8186: Add venc node Eugen Hristev
2024-01-02 9:14 ` AngeloGioacchino Del Regno
2024-01-29 10:41 ` (subset) [PATCH v3 0/6] video encoder on mt8186 AngeloGioacchino Del Regno
2024-01-29 10:47 ` AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c2c42f6-e10a-4ff1-89c7-8635b8f8b73e@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=andrew-ct.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@collabora.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tiffany.lin@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox