Re: [PATCH 0/7] platform/x86: uniwill-laptop: Support additional features

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2135 bytes --]

On Sat, 30 May 2026, Armin Wolf wrote:

> This patch series adds support for various new features to the
> uniwill-laptop driver. The first patch adds support for the keyboard
> backlight available on some models, while the next three patches
> add support for additional WMI events, USB powershare and AC auto
> boot. The last four patches finally add support for additional devices.
> 
> The patch series depends on commit b1a9b7a904af ("leds: Introduce the multi_max_intensity sysfs attribute")
> currently sitting inside the for-leds-next branch of the LED subsystem
> tree. Without said commit the first patch will apply but not build.
> 
> All patches have been tested on my Tuxedo InfinityBook Pro 15 Gen 10
> AMD and most work flawlessly, only the AC auto boot feature seems to
> be broken on my device. I decided to still include the patch because
> it works on other devices.
> 
> Armin Wolf (7):
>   platform/x86: uniwill-laptop: Add keyboard backlight support
>   platform/x86: uniwill-laptop: Handle screen-related events
>   platform/x86: uniwill-laptop: Add AC auto boot support
>   platform/x86: uniwill-laptop: Add support for USB powershare
>   platform/x86: uniwill-laptop: Add support for the MACHENIKE L16 Pro
>   platform/x86: uniwill-laptop: Add support for the AiStone X4SP4NAL
>   platform/x86: uniwill-laptop: Add lightbar support for LAPQC71A/B
> 
>  .../ABI/testing/sysfs-driver-uniwill-laptop   |  25 +
>  .../admin-guide/laptops/uniwill-laptop.rst    |  27 +
>  drivers/platform/x86/uniwill/uniwill-acpi.c   | 609 +++++++++++++++++-
>  drivers/platform/x86/uniwill/uniwill-wmi.h    |   2 +
>  4 files changed, 650 insertions(+), 13 deletions(-)

Unfortunately, I got this error after applying this series on top of 
review-ilpo-next:

drivers/platform/x86/uniwill/uniwill-acpi.c: In function ‘uniwill_kbd_led_init’:
drivers/platform/x86/uniwill/uniwill-acpi.c:1827:49: error: ‘struct mc_subled’ has no member named ‘max_intensity’; did you mean ‘intensity’?
 1827 |                 data->kbd_led_mc_subled_info[i].max_intensity = KBD_LED_MAX_INTENSITY;


-- 
 i.