public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: "Fernando Fernandez Mancera" <fmancera@suse.de>,
	"Ricardo B. Marlière" <rbm@suse.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Simon Horman" <horms@kernel.org>,
	"Shuah Khan" <shuah@kernel.org>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: net: fib-onlink-tests: Set high metric for default IPv6 route
Date: Fri, 19 Dec 2025 08:51:48 -0700	[thread overview]
Message-ID: <9c979662-cdd9-4733-911d-b1071b7c2912@gmail.com> (raw)
In-Reply-To: <9a3f7b60-37e3-470e-b9f7-8cda5ddccb59@suse.de>

On 12/19/25 7:51 AM, Fernando Fernandez Mancera wrote:
> It would probably require some work on the test but I think it could
> benefit from using two different network namespaces. Currently it is
> using PEER_NS and the default. I think avoiding the default one is
> beneficial for everyone as it ensures the state is clean and that the
> test won't interrupt the system connectivity.
> 
> Other tests already do that, e.g some tests in fib_tests.sh use ns1 and
> ns2 namespaces.
> 
> What do you all think?

agreed.


  reply	other threads:[~2025-12-19 15:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-18 12:20 [PATCH] selftests: net: fib-onlink-tests: Set high metric for default IPv6 route Ricardo B. Marlière
2025-12-18 16:01 ` David Ahern
2025-12-19 14:51 ` Fernando Fernandez Mancera
2025-12-19 15:51   ` David Ahern [this message]
2025-12-21 14:59     ` Ricardo B. Marlière

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c979662-cdd9-4733-911d-b1071b7c2912@gmail.com \
    --to=dsahern@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fmancera@suse.de \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rbm@suse.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox