From: Aurabindo Pillai <aurabindo.pillai@amd.com>
To: "José Pekkarinen" <jose.pekkarinen@foxhound.fi>,
harry.wentland@amd.com, sunpeng.li@amd.com,
Rodrigo.Siqueira@amd.com, skhan@linuxfoundation.org
Cc: alexander.deucher@amd.com, christian.koenig@amd.com,
Xinhui.Pan@amd.com, airlied@gmail.com, daniel@ffwll.ch,
dillon.varone@amd.com, Jun.Lei@amd.com, george.shen@amd.com,
samson.tam@amd.com, SyedSaaem.Rizvi@amd.com,
stable@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] drm/amd/display: remove redundant check
Date: Mon, 30 Oct 2023 13:39:15 -0400 [thread overview]
Message-ID: <9ca19ca8-d3c6-4789-a9d8-4f1637bfa71e@amd.com> (raw)
In-Reply-To: <20231030171748.35482-1-jose.pekkarinen@foxhound.fi>
On 2023-10-30 13:17, José Pekkarinen wrote:
> This patch addresses the following warning spotted by
> using coccinelle where the case checked does the same
> than the else case.
>
> drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c:4664:8-10: WARNING: possible condition with no effect (if == else)
>
> Fixes: 974ce181 ("drm/amd/display: Add check for PState change in DCN32")
>
> Cc: stable@vger.kernel.org
> Signed-off-by: José Pekkarinen <jose.pekkarinen@foxhound.fi>
> ---
> .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> index ecea008f19d3..d940dfa5ae43 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> @@ -4661,10 +4661,6 @@ void dml32_CalculateMinAndMaxPrefetchMode(
> } else if (AllowForPStateChangeOrStutterInVBlankFinal == dm_prefetch_support_uclk_fclk_and_stutter) {
> *MinPrefetchMode = 0;
> *MaxPrefetchMode = 0;
> - } else if (AllowForPStateChangeOrStutterInVBlankFinal ==
> - dm_prefetch_support_uclk_fclk_and_stutter_if_possible) {
> - *MinPrefetchMode = 0;
> - *MaxPrefetchMode = 3;
> } else {
> *MinPrefetchMode = 0;
> *MaxPrefetchMode = 3;
Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
next prev parent reply other threads:[~2023-10-30 17:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 17:17 [PATCH] drm/amd/display: remove redundant check José Pekkarinen
2023-10-30 17:39 ` Aurabindo Pillai [this message]
2023-10-31 5:48 ` Greg KH
2023-10-31 11:42 ` José Pekkarinen
2023-10-31 12:20 ` Greg KH
2023-10-31 12:32 ` José Pekkarinen
2023-10-31 16:41 ` Aurabindo Pillai
-- strict thread matches above, loose matches on Subject: below --
2023-10-30 17:04 José Pekkarinen
2023-10-29 12:44 José Pekkarinen
2023-10-30 13:52 ` Aurabindo Pillai
2023-10-30 16:26 ` José Pekkarinen
2023-10-30 16:53 ` Aurabindo Pillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ca19ca8-d3c6-4789-a9d8-4f1637bfa71e@amd.com \
--to=aurabindo.pillai@amd.com \
--cc=Jun.Lei@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=SyedSaaem.Rizvi@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dillon.varone@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=george.shen@amd.com \
--cc=harry.wentland@amd.com \
--cc=jose.pekkarinen@foxhound.fi \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samson.tam@amd.com \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox