From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC2EB322A2E for ; Sun, 10 May 2026 19:50:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=216.40.44.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778442640; cv=none; b=FgCIOEjJEo4kN7462GTnHVuINF49RTaxqN5Ubi0/4FYMmnUZHqJSxwsXS9oDEpyxfJktNve/QURfJvwXPjXJAVZ8NfqYFmEaymTZq8yVCPIafO3+WrnTJoEskamwJuXCkjjM0/gSXyb6LRV31DF2ksod93NTEaNwyu7gLTIa+lY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778442640; c=relaxed/simple; bh=oAxTzzcGSeyFBmQp9GoqUpFegR3tFsEbQzAWjR5QUQY=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=Z0DrPtHae9aVfeFoAmSRcmi153pyA1dx1Qu9mOH0077X13spC31DRHVY+/K7jg+ctsTQYqnc0fKSuK6H0cMQYcVzCVpAthjDODOejFqS81UkdqBkTXv3LTJ2agZOSoLf/QOyQun3srGutnRfTLZZJfRsUbkyRi0Px/42qxgvLSg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com; spf=pass smtp.mailfrom=perches.com; arc=none smtp.client-ip=216.40.44.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=perches.com Received: from omf03.hostedemail.com (lb01a-stub [10.200.18.249]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 93F7E1C1212; Sun, 10 May 2026 19:31:02 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf03.hostedemail.com (Postfix) with ESMTPA id 2230D6000A; Sun, 10 May 2026 19:31:01 +0000 (UTC) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Sun, 10 May 2026 12:31:00 -0700 From: Joe Perches To: Ethan Nelson-Moore Cc: linux-kernel@vger.kernel.org, Andy Whitcroft , Lukas Bulwahn , Dwaipayan Ray Subject: Re: checkpatch false positive for "do not use assignment in if condition" In-Reply-To: References: Message-ID: <9cae630a9e9b95caa90dd92b4e3252e8@perches.com> X-Sender: joe@perches.com Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspamout07 X-Rspamd-Queue-Id: 2230D6000A X-Stat-Signature: 41tuqgj7zd546c45b9s8q74sa331cgjx X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX194AfLw2s730YC45a/lhaKnVS2jenH12gY= X-HE-Tag: 1778441461-452985 X-HE-Meta: U2FsdGVkX1/M3JPxViJ5sKMGJR6a7WzJBUYJvj7GqmWQnZYl4O/MbW5mm2REjxRuRGXu5T/kWRF3vS0E2YyReFzo1aPI9JKL/uE3KzmgBwwnZy4gHunuU9ED0jnQzxS+s0ipN7CYdGzIz4cIXbUH4SJj9YGDSTplMteoLLPJgj+r0JYf+EWHHdZVlXHv8oP0PjbOFCq/DYpu+g9X3kN8NVg2wEgsjsAOwQiNe5d0L70PM5zZX23FMflsF6EpIOUu/kDNj5mgdF0bdFtp2ohtdjxZmKRWrFcBRRpiGRm2gGwHG6mwzuA5s9ujbQvodroy7VFdVSjOYJo= On 2026-05-09 17:20, Ethan Nelson-Moore wrote: > On Sat, May 9, 2026 at 2:53 PM Ethan Nelson-Moore > wrote: >> These lines do not even contain =. >> Could someone look into why this happened? > > The lines *after* the affected patch hunks do have an assignment in > the if condition. checkpatch is fundamentally stupid and an incomplete parser. Rely on your brain to ignore its incorrect bleats when it's wrong. FYI it's looking for a single equal sign in the statement