From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
John Garry <john.garry@huawei.com>
Cc: <linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ata: pata_cs5535: Fix W=1 warnings
Date: Wed, 29 Jun 2022 16:32:17 +0300 [thread overview]
Message-ID: <9caef01c-b601-c19f-10eb-720e8d7b35dc@omp.ru> (raw)
In-Reply-To: <69ed5587-52fd-4171-b97f-091df8b377c6@opensource.wdc.com>
On 6/29/22 4:51 AM, Damien Le Moal wrote:
>> x86_64 allmodconfig build with W=1 gives these warnings:
>>
>> drivers/ata/pata_cs5535.c: In function ‘cs5535_set_piomode’:
>> drivers/ata/pata_cs5535.c:93:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable]
>> u32 reg, dummy;
>> ^~~~~
>> drivers/ata/pata_cs5535.c: In function ‘cs5535_set_dmamode’:
>> drivers/ata/pata_cs5535.c:132:11: error: variable ‘dummy’ set but not used [-Werror=unused-but-set-variable]
>> u32 reg, dummy;
>> ^~~~~
>> cc1: all warnings being treated as errors
>>
>> Mark variables 'dummy' as "maybe unused" to satisfy when rdmsr() is
>> stubbed, which is the same as what we already do in pata_cs5536.c .
>>
>> Signed-off-by: John Garry <john.garry@huawei.com>
>
> Applied to for-5.20. Thanks !
Why not to 5.19? The warnings are fatal as can be seen from the commit log...
MBR, Sergey
next prev parent reply other threads:[~2022-06-29 13:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 13:12 [PATCH] ata: pata_cs5535: Fix W=1 warnings John Garry
2022-06-28 8:59 ` Damien Le Moal
2022-06-28 9:27 ` John Garry
2022-06-28 10:05 ` Sergey Shtylyov
2022-06-28 18:39 ` Sergey Shtylyov
2022-06-29 7:41 ` John Garry
2022-06-29 8:24 ` Damien Le Moal
2022-06-29 1:14 ` Damien Le Moal
2022-06-29 1:51 ` Damien Le Moal
2022-06-29 13:32 ` Sergey Shtylyov [this message]
2022-06-29 23:03 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9caef01c-b601-c19f-10eb-720e8d7b35dc@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=damien.lemoal@opensource.wdc.com \
--cc=john.garry@huawei.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox