From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1450C10F2 for ; Sat, 22 Nov 2025 13:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763818741; cv=none; b=N77flp5srJD1ZPk6hAOwcM9XuavOF2ELvT0Z2BDUDKrhXNo15kM8uBu0qmCQTW1a9zsA+5E7JkfUhZ0MqZpe6uT4g+IkGFSThsGTRhLBNqB+tyWbh3GB/UYQXNVUD3D8OGRalqxcSzD9kBJ6zEVt0NnIFw7qtu9e3h4tIFkA7g4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763818741; c=relaxed/simple; bh=7iiUDV5uYgWWv66PWt9aviOFITCMKNH/gMzmfXDIgQQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=s/RvOsog+fTtD+aHzM2VA+RSZAOQS9UZ/bjhBrWAoNPwjlD9rz0puqJhC3E6bqCnFGXhhTkzTwLYlXnRV6RXxHyOPqwtuziM3yPW5gdU12W2K4rbWe3YY3hLJBeHmuqfomHxb5cMKUDCUFyjCgX8I4ShneIoM2I2z0EZ7ZNsKMo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jAKXcywd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Myn19mN2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jAKXcywd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Myn19mN2" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AMCdWKe2693440 for ; Sat, 22 Nov 2025 13:38:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= T1kiOU7zHHRfCpTkZ1/m/6Ad+XotlTWnDzTmokj1Uqs=; b=jAKXcywd+z1jj0E7 cnufw1sRGGRNMz92E4JJxBl7kO1YoZ70KqpuVvC3OYLq3lRD8ZyBUV/6pAA0+qlr iETqzThzad9+bhApzcezGOWDBcAimalgE0dDmtu7dR/oUQPFIojT0gGoO6NJIJjV 8+iMWQEoIBOseCS1vnX1Tw1VzR/EPQFHxrlzVTshJkvscowyRPoNLCbDK+J5i731 4qo6eHLu3mHnvJgvqCH4hn1OSrZ4KBKQqpWo2zPVCC5gv+S5WgXYD+LJYpytDXVs iwdGVO5LQ+W4Edglz2U1cFb8m5/e6l3Kbjw8r3vEUBoDSh9ltHefOrwWmm/1XPMN EmxEsw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ak6cdrq79-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 22 Nov 2025 13:38:58 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-4ee07f794fcso9970181cf.2 for ; Sat, 22 Nov 2025 05:38:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763818738; x=1764423538; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=T1kiOU7zHHRfCpTkZ1/m/6Ad+XotlTWnDzTmokj1Uqs=; b=Myn19mN259GzXhYd75MRqEodDBiyRu5OeZvyYA/ADvUFMikzyoNgJsz0I7YeSVLdyA pQt5EVJOnAtjZDM12DBRqRn1yNRemVf221+SB9WHqsoZ9IF6Vlt1oDZ9rEUBx3bRW67K GVYciOKwTAH7l+bI15RQRTkH3g32JHrrt+WIaKk9OH4cJJV36wnS+zvfoEK8yNf5ro3H +3lJxnd7no9IxECUiLJ1aa7CO/DdZw5s4PCuG0L83hkdcDvXHU8ik6Yhqt54HGLKC05E n67BhZj3y8zAtCRE2gRVvVLL84BS77w7rKzLgn4fckuT9zLmysVjUayCenHSphFsQNgM 491A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763818738; x=1764423538; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=T1kiOU7zHHRfCpTkZ1/m/6Ad+XotlTWnDzTmokj1Uqs=; b=hj+kWMbF4JanesOD2adoGDLTVPLsJRhpwXHtLh9opu53EJQen71XwEnPrtBWvoiMMP wDnU7pDXIZxKt3/o9bt1259/JG69V/jXRFbF0Nt+8U2Fkj7gdACxGqL8qhlIQbykYUNf 6xweEvoRF/syylU+3eXQqlYzUvhyQG6NMbvK564C8xqVDwR/H8nTflF1zC7bfQdEIHLd /p3koMtdeuRskSWfNYSmBG0BykWKVqCH+Vc6xCxqNLKP+pCFJ00l378CoAeNvNlx7s7x Zj672hnBC754SsJSaHgBVc58f+LsZ2SXzz7NlBZaP4lyXfrKJuhkj8BiTSQ9odu3xaom nj/A== X-Forwarded-Encrypted: i=1; AJvYcCXDRiFFA6Gb70Pwa0oPf0xm5XlCY6HciefmmPWh3dqq3+8mIQwkL5yYh/Rxs4QcRguvWPIZZUjqlNASoOk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy3LeQyEtD2g42unXjtqLTk2V66Tt4YqPLVCgW7xnz2iHEr0eA4 sEtk0uWRqiLjlrghcA6VBCnecqHwX1/5paExeYo7rBLZyKERnCyBPfNZ4bZEfcndOYqwoD9ic2Y 8UCUCwiEt3uBCxakz1PiSDR7va4V4oeGi2QiXeeUEQXWLO/KKNV7UfRBnJVUgj+dUi24= X-Gm-Gg: ASbGncuJtvhNSt8B4lW/XUDIXyUKSt/YUJYbPK5zVMlnbwNTwVBcDHie3Xc4STIApzO 79Tezo54WTxBPTT3sJ7YIFlxMty/TCIKAqX73+bxpFRb35WkwObNDMfM13VnuiFnlMkE+Tk2z96 qyun+AgQcL/HXNeBR3QLUlOYGi90ufJANF98Wc+EoQSOVSHVaXB0plnviDHDHzg5X98reedaqAq fGI28oIu6Lodzvk0koVy0CS8g3+viyfAQ7GGe8qffAmYJFbZ3ZE3mNrHH5eyoTIi+264OGBKQXC v8lCTW9YRpUvKGHaGT4sgXySMSYdSA/IJzX7b8zc5myaXYJ3rr48Z1S+fXxszXBxT5dMKYAIYE/ WMUqFcwDIjND+oNpVQYCNhL629eISVlR1Q0UQO2JqfjGE5n0FCwIVCnBve6fBuRHpOz4= X-Received: by 2002:ac8:7c48:0:b0:4ee:1e95:af63 with SMTP id d75a77b69052e-4ee5894e4camr57436761cf.10.1763818738323; Sat, 22 Nov 2025 05:38:58 -0800 (PST) X-Google-Smtp-Source: AGHT+IF2lPPngRjH98213/0iV6w7rCFVvGxRvqEr5IE7cDS/Bmlf93oCCzqTQwYTweMRgaNxHpWPVg== X-Received: by 2002:ac8:7c48:0:b0:4ee:1e95:af63 with SMTP id d75a77b69052e-4ee5894e4camr57436521cf.10.1763818737837; Sat, 22 Nov 2025 05:38:57 -0800 (PST) Received: from [192.168.119.202] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b7654fd4e51sm735525466b.42.2025.11.22.05.38.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Nov 2025 05:38:57 -0800 (PST) Message-ID: <9cc55934-6980-4673-8501-2d1efe2f816e@oss.qualcomm.com> Date: Sat, 22 Nov 2025 14:38:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/6] drm/msm/a6xx: Retrieve gmu core range by index To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Jessica Zhang Cc: Dan Carpenter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20251122-qcs615-spin-2-v3-0-9f4d4c87f51d@oss.qualcomm.com> <20251122-qcs615-spin-2-v3-1-9f4d4c87f51d@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251122-qcs615-spin-2-v3-1-9f4d4c87f51d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=bsdBxUai c=1 sm=1 tr=0 ts=6921bcf2 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=S4gWedWR7TB3ctbtemkA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: 2t-fOvkRV-JmWiXP-SyBIJqVB3NhYXpt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTIyMDExMSBTYWx0ZWRfX/cYoGG334jCe wwnkVXzQf7Gw44hy9wlG2Onizhm34oPnO9f7fAGB+zoOvyopaRJQ/E5WQOa2+KRt9FjKM5wt/gg /ez6Es2gYkeHYciJdRQtaiKgMaF9opKU0jjPM62uyMig7IdWKu0JNOGaWRdxcV0Gbw8oEFnHJld IJJ4AXWiOLFzyGZ+uDmnq0s6aQ2D793KNNfYEHcjqZXPqkcKhxK0XhJjlIX6kEhVw3y9TQ6l7fp A+COEd9G3UsXm7HQCe1TjW6FAz3HJncWwoIKwCVF+UarS+/WOxYdcrk+BzNCGU/QXUSFKYf1v4+ WpeRg7+17BT5N7jofeM7IBmt0sys4ln5jm6n1czzru4RT+BLQO1rspMpFa+hfWCYwsHl5jFwmKy l0wbQmPVgCj0InlFY0a1w1WFHkXN/Q== X-Proofpoint-GUID: 2t-fOvkRV-JmWiXP-SyBIJqVB3NhYXpt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-22_05,2025-11-21_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 clxscore=1015 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511220111 On 11/21/25 10:52 PM, Akhil P Oommen wrote: > Some GPUs like A612 doesn't use a named register range resource. This > is because the reg-name property is discouraged when there is just a > single resource. > > To address this, retrieve the 'gmu' register range by its index. It is > always guaranteed to be at index 0. > > Signed-off-by: Akhil P Oommen > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > index 5903cd891b49..9662201cd2e9 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c > @@ -2029,21 +2029,19 @@ static int cxpd_notifier_cb(struct notifier_block *nb, > return 0; > } > > -static void __iomem *a6xx_gmu_get_mmio(struct platform_device *pdev, > - const char *name, resource_size_t *start) > +static void __iomem *a6xx_gmu_get_mmio(struct platform_device *pdev, resource_size_t *start) Can we drop this and just use devm_platform_get_and_ioremap_resource()? Konrad