From: Nikolaus Voss <nv@vosn.de>
To: Marek Vasut <marex@denx.de>
Cc: Liu Ying <victor.liu@oss.nxp.com>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Liu Ying <victor.liu@nxp.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Fabio Estevam <festevam@denx.de>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Miquel Raynal <miquel.raynal@bootlin.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
nikolaus.voss@haag-streit.com
Subject: Re: [PATCH] drm: bridge: fsl-ldb: fixup mode on freq mismatch
Date: Mon, 02 Dec 2024 18:03:16 +0100 [thread overview]
Message-ID: <9cc55af202690bad0616bee76430133d@vosn.de> (raw)
In-Reply-To: <50ee0207-b37a-4a6a-83fe-32a7a43645ce@denx.de>
On 02.12.2024 13:56, Marek Vasut wrote:
> On 12/2/24 7:32 AM, Liu Ying wrote:
>> On 11/27/2024, Nikolaus Voss wrote:
>>> LDB clock has to be a fixed multiple of the pixel clock.
>>> As LDB and pixel clock are derived from different clock sources
>>> (at least on imx8mp), this constraint cannot be satisfied for
>>> any pixel clock, which leads to flickering and incomplete
>>> lines on the attached display.
>>>
>>> To overcome this, check this condition in mode_fixup() and
>>> adapt the pixel clock accordingly.
>>>
>>> Cc: <stable@vger.kernel.org>
>>
>> It looks like stable is not effectively Cc'ed.
>> Need a Fixes tag?
> Isn't this fix effectively superseded by series
>
> [PATCH 0/5] clk: Fix simple video pipelines on i.MX8
>
> ?
Maybe. I wasn't aware of the series. Looking at it, the change is
rather complex and not suitable for the stable series.
My intention was to get a simple fix which doesn't potentially
break anything. It wouldn't even break the patch series you mentioned.
--
Nikolaus Voss
next prev parent reply other threads:[~2024-12-02 17:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 15:45 [PATCH] drm: bridge: fsl-ldb: fixup mode on freq mismatch Nikolaus Voss
2024-11-26 18:20 ` Luca Ceresoli
2024-11-30 9:35 ` Dmitry Baryshkov
2024-11-30 18:57 ` Nikolaus Voss
2024-11-30 20:14 ` Dmitry Baryshkov
2024-12-02 6:32 ` Liu Ying
2024-12-02 10:13 ` Nikolaus Voss
2024-12-03 2:22 ` Liu Ying
2024-12-03 3:12 ` Marek Vasut
2024-12-03 7:20 ` Nikolaus Voss
2024-12-03 23:40 ` Marek Vasut
2024-12-04 10:55 ` Nikolaus Voss
2024-12-07 11:30 ` Marek Vasut
2024-12-09 8:46 ` Nikolaus Voss
2024-12-09 21:46 ` Marek Vasut
2024-12-11 16:54 ` Nikolaus Voss
2024-12-03 7:54 ` Nikolaus Voss
2024-12-23 9:44 ` Liu Ying
2024-12-09 7:41 ` Martin Kepplinger
2024-12-02 12:56 ` Marek Vasut
2024-12-02 17:03 ` Nikolaus Voss [this message]
2024-12-02 19:11 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cc55af202690bad0616bee76430133d@vosn.de \
--to=nv@vosn.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@denx.de \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=marex@denx.de \
--cc=miquel.raynal@bootlin.com \
--cc=neil.armstrong@linaro.org \
--cc=nikolaus.voss@haag-streit.com \
--cc=rfoss@kernel.org \
--cc=victor.liu@nxp.com \
--cc=victor.liu@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox