From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2472A7083C for ; Mon, 9 Mar 2026 23:50:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773100234; cv=none; b=bBkQUtOGUBZs9FLngisT6SGciE/PnSopk2bZcT/tgYTrqp2HF0bQr2yKJUZgjzYEYmYEQzoObNMOV6qtxMaG7bRUl7re2ApyaB6flCBOrFuCG/da9jkc9P/tUg3uvs0nNKi81ge4cBgn3Dy+8wSFHRGonO6oCvBtip0j3P0RjNU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773100234; c=relaxed/simple; bh=2I18mxmMPuansctcCshuBD3YLdIUGz4SaCX8PGHGUaw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=U5qWSPkDTVHanKAnGBK50TOkCXjCGMH4nWjqpLFBOStucADC7GBUAd+lFoxNiuWDBhhJ65l6lR9NP589yIYX/OObLT6bfWA44nzjAEVLb5fVJ3IyCKxG/ttJKNt4PKQ3Yx3nzNHolKOOywsgR3VlWCO/AFxEGrq9D0KC5dtFefE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IQgsSFbn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QJKcfg93; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IQgsSFbn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QJKcfg93" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 629HCEwQ1212197 for ; Mon, 9 Mar 2026 23:50:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Usf2c8oheBhN4rTUg/6UxDx9DMs4PXDC10F9BFyFRk0=; b=IQgsSFbn0KFUnTb1 KDrlCb6DNjAXoPA8Nwvhml10EY3QiGV6sjcWdNcnFvTJTrnhRVGJDtbhXabxBPnO BFpeIJL2HBaHQH7kQciQbJgYijhb3lehwUQC0cKolzAqoof+fVPKpuoHYKhB9Hgl BuQBFoeu9Hd+OfySMjSvJpeHu8TWZsotLGbmQdkOPDDb3/sqO2JBA9vS5polGetk fL4zv4ya9KZWdQVnq0gUkDwX3qHUozGvBXji0UFEYja0gt+AGzmuTNPejNDJohox OT/YvTyzG3CdAs6InKcMXboMSg94ba5A1lPk9z5x7jvLPjgpl2gEd4edPd7aC87I eaYn/w== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cswwkj3g4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 23:50:32 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-2be21f89332so7691312eec.0 for ; Mon, 09 Mar 2026 16:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773100231; x=1773705031; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Usf2c8oheBhN4rTUg/6UxDx9DMs4PXDC10F9BFyFRk0=; b=QJKcfg935m/3Nxo0nrkVWf1wFx+6WjRc0faLfN6gDu0pWYrIGzFdxyrSunaFY4wBth F56hhXo7ElHyNQPepk9vsnUSpvprTClpa9OJkjrxht7VpUVa5617pzxXDZeoCnRlOnmY K/rVfM2JTF+9rFXlnafn5vGNkB5gRsGX53jvgOYcjKGvN4p416bbLHcM6lt6+tvWIIZE 0+Hdnkk479ke9piJE8aCEaq/hreM3K5pcdPMzTicj25hLTYfNsEa2+F+pwrSEsLgc0jN AHesOUpvbmzubSnXrkzPO5vP0fSHKc9vZe7P8z16sPBa+Za9k6updXjJlIo1TQrbUBa4 vjag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773100231; x=1773705031; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Usf2c8oheBhN4rTUg/6UxDx9DMs4PXDC10F9BFyFRk0=; b=KAtVqTZTY4SNJP/W9jfn17Lhxe1w+mtDxRKoDy2yW4mwPFk+Exe9BwbhsYcyncMZtJ jTznLbyaYFQncsxL6bljj3ItRqpPqpaHZb7oyTZnsY0W1M5HkWEkuRJaAicpVy2WCM8/ yB9xLBrF2BtC9nwMpKCcZtI1DzLJNR8/cSCPsdGe1s0XI/Pid4WOac6/Yh6gial05y5U OC6w1WVZSZRN7EY24ZJDrmm50INGei/HhcbgZ5TubeFG7ASFSZqRH/c8oBOGeY8qqx37 bCpWGUjw8Gaj7WHRtdto5ZVKSLjf/aDZYldk3Eky41qDrtQBfLnb3m1muqp6/YennL/+ k9+A== X-Gm-Message-State: AOJu0Yw8m3Sat1mTAvtI7Ds3oXpsUqBCnWlaLjIBPuPmdjj2UVmcPl5c LGnf7WxNivge8EJ56/2h+PbHYJZoGDzPoS1nX92eVEZXIOLnte6UPfqkQSfhW28uWO6ucNy8QkE oCIAXBsXtI2P8iiW5QIQ9SvHiihnsSxAC/7HUPQ2P+MdxJ+B7OiI7NuY0Pcc/ibLVkwI= X-Gm-Gg: ATEYQzwo6KAMV1/CRWSrq659dnqwo5hyyJ5h9hfPtkILuZ51M2VrmE4kacAdc0Ge9Gc lfmWHhfvQcn3cpZJFZzURM9chRZKuzB55WExwyoh1+DGgOYoUkrkz3rTQBxOYU3QOOfsUsky99r onoAT99WDJJxnAmBWYUdUVRK0+kfKdlbU5Dk3zxXrxkcXGqzo3t7xxAs7yJMYY+RiVNUUC8oawd XEgsdQYDUDvAe7M7OJ/0eSnlGjbJzqMDMFwA2g5mZ9L/2b9NO+juIwSdELV4xh+AqZCOUqTcqwx gQ+pCVEMpvbseBrj+GShflShqt708E886YTqMEcG43a3GdGSBoku5+jRpn+JbF91/95uUZrRdU8 ukisg4QaaPhwGXioUGMhBxx66h//OTza3R0BdoqlkMJXGqpCdkgFjwjWuH7jNSBgQwqZVssEl9W dWX+85hsyXO5UEzw== X-Received: by 2002:a05:7022:629f:b0:128:cf80:deea with SMTP id a92af1059eb24-128cf80e01fmr3402121c88.1.1773100230960; Mon, 09 Mar 2026 16:50:30 -0700 (PDT) X-Received: by 2002:a05:7022:629f:b0:128:cf80:deea with SMTP id a92af1059eb24-128cf80e01fmr3402088c88.1.1773100230365; Mon, 09 Mar 2026 16:50:30 -0700 (PDT) Received: from [192.168.1.41] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-128dc848cbcsm3108879c88.7.2026.03.09.16.50.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Mar 2026 16:50:29 -0700 (PDT) Message-ID: <9cc7638f-1232-4cb7-b4d7-cdac66a2f4ba@oss.qualcomm.com> Date: Mon, 9 Mar 2026 16:50:25 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/8] Group QMI service IDs into the QMI header To: Daniel Lezcano , konradybcio@kernel.org, andersson@kernel.org Cc: linux-kernel@vger.kernel.org, Alex Elder , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Johnson , Mathieu Poirier , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Kees Cook , Greg Kroah-Hartman , Arnd Bergmann , Mark Brown , Wesley Cheng , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-sound@vger.kernel.org References: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> Content-Language: en-US From: Jeff Johnson In-Reply-To: <20260309230346.3584252-1-daniel.lezcano@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=cZ/fb3DM c=1 sm=1 tr=0 ts=69af5cc8 cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=J1Y8HTJGAAAA:8 a=1XWaLZrsAAAA:8 a=20KFwNOVAAAA:8 a=KKAkSRfTAAAA:8 a=iox4zFpeAAAA:8 a=ag1SF4gXAAAA:8 a=COk6AnOGAAAA:8 a=JfrnYn6hAAAA:8 a=GmBS2Oju3p3q64JsNm8A:9 a=QEXdDO2ut3YA:10 a=scEy_gLbYbu1JhEsrz4S:22 a=y1Q9-5lHfBjTkpIzbSAN:22 a=cvBusfyB2V15izCimMoJ:22 a=WzC6qhA0u3u7Ye7llzcV:22 a=Yupwre4RP9_Eg_Bd0iYG:22 a=TjNXssC_j7lpFel5tvFf:22 a=1CNFftbPRP8L7MoqJWF3:22 X-Proofpoint-ORIG-GUID: iwxs21JJoyuGMLsM2OvjRJIYXUrD61xq X-Proofpoint-GUID: iwxs21JJoyuGMLsM2OvjRJIYXUrD61xq X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDIxMCBTYWx0ZWRfX8r1T12/Cen9K Tc4Wlc1uJbChjp/NV7yFMyA3qkzGRAF0c0L9v7bsOobFsg8kahauusJDulFt1gjaJOF4Kp2lLH8 9H6UdhtMGj4eafi0EGdKzAOFw4ez6nBQ5KNAAn2BfeG6AzD44cKjbip0MWxkmGM/oVYqBe0hpVG /CFZ4rSRCPbFK9/s+tcQFCnNUm8yHRf52/2YHuGnx0TRWlbJR7DOsNqt6bALtLxl34JW2LruE4e jDiyj7tctLybmCkv+GDf5lDy0646O8tnW3gU59amaSr0H0oOjXGP56Z1oJ6ZqFC06Mr2YxKNvbY wfBtvdKIWtqDwu/EWAv31DTLXVd3XkxSeU2FyQhe9MhaUsN6AR3c02D0zcRdZNLGdV6YY+r/kee 3kf+YuwOZOZLeEEWaNPBkcfDdprSfLkBWPSlN0frSyDdloUfE7tbju1AgB2JLk/afucBFblDe2p RxAnolgu2IErhTJ4TEA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_06,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 impostorscore=0 adultscore=0 priorityscore=1501 phishscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090210 On 3/9/2026 4:03 PM, Daniel Lezcano wrote: > The different subsystems implementing the QMI service protocol are > using their own definition of the service id. It is not a problem but > it results on having those duplicated with different names but the > same value and without consistency in their name. > > It makes more sense to unify their names and move the definitions in > the QMI header file providing a consistent way to represent the > supported protocols. Consequently the different drivers will use them > instead of their own definition of the service id. > > Cc: Alex Elder > Cc: Andrew Lunn > Cc: "David S. Miller" > Cc: Eric Dumazet > Cc: Jakub Kicinski > Cc: Paolo Abeni > Cc: Jeff Johnson > Cc: Bjorn Andersson > Cc: Mathieu Poirier > Cc: Srinivas Kandagatla > Cc: Konrad Dybcio > Cc: Jaroslav Kysela > Cc: Takashi Iwai > Cc: Kees Cook > Cc: Greg Kroah-Hartman > Cc: Arnd Bergmann > Cc: Mark Brown > Cc: Wesley Cheng > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-wireless@vger.kernel.org > Cc: ath10k@lists.infradead.org > Cc: ath11k@lists.infradead.org > Cc: ath12k@lists.infradead.org > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-remoteproc@vger.kernel.org > Cc: linux-sound@vger.kernel.org > --- > Daniel Lezcano (8): > soc: qcom: qmi: Enumerate the service IDs of QMI > net: ipa: Use the unified QMI service ID instead of defining it > locally > net: drivers: wireless: ath: Use the unified QMI service ID instead of > defining it locally prefix for wireless drivers is simply wifi: : so s/net: drivers: wireless:/wifi:/ > remoteproc: qcom: Use the unified QMI service ID instead of defining > it locally > slimbus: qcom-ngd-ctrl: Use the unified QMI service ID instead of > defining it locally > soc: qcom: pdr: Use the unified QMI service ID instead of defining it > locally > ALSA: usb-audio: qcom: Use the unified QMI service ID instead of > defining it locally > samples: qmi: Use the unified QMI service ID instead of defining it > locally > > drivers/net/ipa/ipa_qmi.c | 6 ++---- > drivers/net/wireless/ath/ath10k/qmi.c | 2 +- > drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h | 1 - > drivers/net/wireless/ath/ath11k/qmi.c | 2 +- > drivers/net/wireless/ath/ath11k/qmi.h | 1 - > drivers/net/wireless/ath/ath12k/qmi.c | 2 +- > drivers/net/wireless/ath/ath12k/qmi.h | 1 - > drivers/remoteproc/qcom_sysmon.c | 2 +- > drivers/slimbus/qcom-ngd-ctrl.c | 5 ++--- > drivers/soc/qcom/pdr_interface.c | 4 ++-- > drivers/soc/qcom/pdr_internal.h | 3 --- > drivers/soc/qcom/qcom_pd_mapper.c | 2 +- > include/linux/soc/qcom/qmi.h | 12 ++++++++++++ > samples/qmi/qmi_sample_client.c | 2 +- > sound/usb/qcom/qc_audio_offload.c | 2 +- > sound/usb/qcom/usb_audio_qmi_v01.h | 1 - You are touching a lot of subsystems with a single series. How do you plan on having these land? Do you have a maintainer who will take all of these through their tree? > 16 files changed, 25 insertions(+), 23 deletions(-) >