From: Shuah Khan <skhan@linuxfoundation.org>
To: Nathan Chancellor <nathan@kernel.org>
Cc: shuah@kernel.org, tglx@linutronix.de,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] selftests: Make ksft_exit functions return void instead of int
Date: Wed, 24 Apr 2024 10:27:59 -0600 [thread overview]
Message-ID: <9cceb519-e627-4041-bbd4-227e47d5d209@linuxfoundation.org> (raw)
In-Reply-To: <20240424161059.GA904896@dev-arch.thelio-3990X>
On 4/24/24 10:10, Nathan Chancellor wrote:
> On Wed, Apr 24, 2024 at 10:00:12AM -0600, Shuah Khan wrote:
>>>>> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
>>>>> ---
clone patch
>>>>> tools/testing/selftests/clone3/clone3_clear_sighand.c | 2 +-
>>>>> tools/testing/selftests/clone3/clone3_set_tid.c | 4 +++-
ipc patch
>>>>> tools/testing/selftests/ipc/msgque.c | 11 +++++------
kselftest.h patch
>>>>> tools/testing/selftests/kselftest.h | 12 ++++++------
membarrier patch etc...
>>>>> .../selftests/membarrier/membarrier_test_multi_thread.c | 2 +-
>>>>> .../selftests/membarrier/membarrier_test_single_thread.c | 2 +-
>>>>> tools/testing/selftests/mm/compaction_test.c | 6 +++---
>>>>> tools/testing/selftests/mm/cow.c | 2 +-
>>>>> tools/testing/selftests/mm/gup_longterm.c | 2 +-
>>>>> tools/testing/selftests/mm/gup_test.c | 4 ++--
>>>>> tools/testing/selftests/mm/ksm_functional_tests.c | 2 +-
>>>>> tools/testing/selftests/mm/madv_populate.c | 2 +-
>>>>> tools/testing/selftests/mm/mkdirty.c | 2 +-
>>>>> tools/testing/selftests/mm/pagemap_ioctl.c | 4 ++--
>>>>> tools/testing/selftests/mm/soft-dirty.c | 2 +-
>>>>> tools/testing/selftests/pidfd/pidfd_fdinfo_test.c | 2 +-
>>>>> tools/testing/selftests/pidfd/pidfd_open_test.c | 4 +++-
>>>>> tools/testing/selftests/pidfd/pidfd_poll_test.c | 2 +-
>>>>> tools/testing/selftests/pidfd/pidfd_test.c | 2 +-
>>>>> tools/testing/selftests/resctrl/resctrl_tests.c | 6 +++---
>>>>> tools/testing/selftests/sync/sync_test.c | 3 +--
>>>>> tools/testing/selftests/timers/adjtick.c | 4 ++--
>>>>> tools/testing/selftests/timers/alarmtimer-suspend.c | 4 ++--
>>>>> tools/testing/selftests/timers/change_skew.c | 4 ++--
>>>>> tools/testing/selftests/timers/freq-step.c | 4 ++--
>>>>> tools/testing/selftests/timers/leap-a-day.c | 10 +++++-----
>>>>> tools/testing/selftests/timers/leapcrash.c | 4 ++--
>>>>> tools/testing/selftests/timers/mqueue-lat.c | 4 ++--
>>>>> tools/testing/selftests/timers/posix_timers.c | 12 ++++++------
>>>>> tools/testing/selftests/timers/raw_skew.c | 6 +++---
>>>>> tools/testing/selftests/timers/set-2038.c | 4 ++--
>>>>> tools/testing/selftests/timers/set-tai.c | 4 ++--
>>>>> tools/testing/selftests/timers/set-timer-lat.c | 4 ++--
>>>>> tools/testing/selftests/timers/set-tz.c | 4 ++--
>>>>> tools/testing/selftests/timers/skew_consistency.c | 4 ++--
>>>>> tools/testing/selftests/timers/threadtest.c | 2 +-
>>>>> tools/testing/selftests/timers/valid-adjtimex.c | 6 +++---
>>>>> tools/testing/selftests/x86/lam.c | 2 +-
>>>>> 38 files changed, 81 insertions(+), 79 deletions(-)
>>>>>
>>>>
>>>> Please generate separate patches for each test so it is easy to apply
>>>> them and also reduce merge conflicts.
>>>
>>> Is applying 30+ patches easier than applying just one? It is not a
>>> trivial amount of work for me to break this series up into individual
>>> patches but I will do so if you really want me to. I based this on the
>>> kselftest tree directly so that it would apply cleanly.
>>>
>>
>> I am not asking each file to be a separate patch.
>
> What granularity would you like? One per folder in
> tools/testing/selftest (i.e., clone3, ipc, membarrier, etc)?
Correct. It will be 10 patches. Please see above for the split I have
in mind.
thanks,
-- Shuah
prev parent reply other threads:[~2024-04-24 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 15:37 [PATCH] selftests: Make ksft_exit functions return void instead of int Nathan Chancellor
2024-04-19 16:50 ` Muhammad Usama Anjum
2024-04-22 14:15 ` Thomas Gleixner
2024-04-24 13:44 ` Shuah Khan
2024-04-24 15:05 ` Nathan Chancellor
2024-04-24 16:00 ` Shuah Khan
2024-04-24 16:10 ` Nathan Chancellor
2024-04-24 16:27 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cceb519-e627-4041-bbd4-227e47d5d209@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox