From: Arjan van de Ven <arjan@linux.intel.com>
To: patrickg <patrickg@supermicro.com>,
len.brown@intel.com, linux-kernel@vger.kernel.org
Cc: mingo@kernel.org, alek.du@intel.com, feng.tang@intel.com
Subject: Re: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences
Date: Fri, 13 Jul 2018 12:40:41 -0700 [thread overview]
Message-ID: <9cdcf3bb-4d01-19cc-536f-4745ecb058c6@linux.intel.com> (raw)
In-Reply-To: <fdf96605-a4a0-049b-51c9-1e68cc2a9b93@supermicro.com>
On 7/13/2018 12:19 PM, patrickg wrote:
> This RFC patch is intended to allow bypass CPUID, MSR and QuickPIT calibration methods should the user desire to.
>
> The current ordering in ML x86 tsc is to calibrate in the order listed above; returning whenever there's a successful calibration. However there are certain BIOS/HW Designs for overclocking that cause the TSC to change along with the max core clock; and simple 'trusting' calibration methodologies will lead to the TSC running 'faster' and eventually, TSC instability.
>
that would be a real violation of the contract between cpu and OS: tsc is not supposed to change for the duration of the boot
> I only know that there's a use-case for me to want to be able to skip CPUID calibration, however I included args for skipping all the rest just so that all functionality is covered in the long run instead of just one use-case.
wouldn't it be better to start the detailed calibration with the value from CPUID instead; that way we also properly calibrate spread spectrum etc...
I thought we switched to that recently to be honest...
next prev parent reply other threads:[~2018-07-13 19:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 19:19 [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences patrickg
2018-07-13 19:40 ` Arjan van de Ven [this message]
2018-07-13 19:54 ` patrickg
2018-07-13 19:54 ` patrickg
2018-07-14 2:40 ` Brown, Len
2018-07-20 22:27 ` patrickg
2018-07-24 19:45 ` patrickg
2018-07-26 19:21 ` patrickg
2018-08-16 17:28 ` patrickg
2018-10-25 17:12 ` patrickg
2018-10-25 18:01 ` Prarit Bhargava
2018-10-25 19:13 ` patrickg
2018-12-03 19:37 ` Patrick Geary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cdcf3bb-4d01-19cc-536f-4745ecb058c6@linux.intel.com \
--to=arjan@linux.intel.com \
--cc=alek.du@intel.com \
--cc=feng.tang@intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=patrickg@supermicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox