Re: [PATCH] fs/Kconfig: more consistent configuration of XFS

[aq <aquynh@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

On 4/28/05, Christoph Hellwig <hch@infradead.org> wrote:
> On Thu, Apr 28, 2005 at 05:38:40PM +0900, aq wrote:
> > I dont see why we should keep a file in kernel tree without using it
> > (since the patch removes "source xfs/Kconfig). Anyway, here is another
> > patch that doesnt remove fs/xfs/Kconfig.
> 
> No, you should not remove usage of it either.
> 

OK, here is another patch. It is up to Andrew to pick the approriate.
But I still prefer the first patch, which provides both consistency in
interface and configuration.

What this patch does:

- Remove "menu" directive from fs/xfs/Kconfig, so XFS configuration is
done in the same screen as other filesystems.
- Move "config XFS_EXPORT " to the bottom, so the menu items aligns
better and consistent with others.
 
# diffstat makefile.fs3.patch 
 Kconfig |   11 ++++-------
 1 files changed, 4 insertions(+), 7 deletions(-)

Signed-off-by: Nguyen Anh Quynh <aquynh@gmail.com>

[-- Attachment #2: makefile.fs3.patch --]
[-- Type: application/octet-stream, Size: 818 bytes --]

diff -Nurp -X dontdiff-aq a/2.6.12-rc3/fs/xfs/Kconfig c/2.6.12-rc3/fs/xfs/Kconfig
--- a/2.6.12-rc3/fs/xfs/Kconfig	2005-03-02 16:38:08.000000000 +0900
+++ c/2.6.12-rc3/fs/xfs/Kconfig	2005-04-28 17:51:47.000000000 +0900
@@ -1,5 +1,3 @@
-menu "XFS support"
-
 config XFS_FS
 	tristate "XFS filesystem support"
 	select EXPORTFS if NFSD!=n
@@ -20,10 +18,6 @@ config XFS_FS
 	  system of your root partition is compiled as a module, you'll need
 	  to use an initial ramdisk (initrd) to boot.
 
-config XFS_EXPORT
-	bool
-	default y if XFS_FS && EXPORTFS
-
 config XFS_RT
 	bool "Realtime support (EXPERIMENTAL)"
 	depends on XFS_FS && EXPERIMENTAL
@@ -82,4 +76,7 @@ config XFS_POSIX_ACL
 
 	  If you don't know what Access Control Lists are, say N.
 
-endmenu
+config XFS_EXPORT
+	bool
+	default y if XFS_FS && EXPORTFS
+