public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: aq <aquynh@gmail.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	Andrew Morton <akpm@osdl.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs/Kconfig: more consistent configuration of XFS
Date: Sat, 30 Apr 2005 11:02:27 +0900	[thread overview]
Message-ID: <9cde8bff05042919025d077eb1@mail.gmail.com> (raw)
In-Reply-To: <20050429212835.GD8699@mars.ravnborg.org>

On 4/30/05, Sam Ravnborg <sam@ravnborg.org> wrote:
> On Thu, Apr 28, 2005 at 06:21:52PM +0900, aq wrote:
> >
> > OK, here is another patch. It is up to Andrew to pick the approriate.
> > But I still prefer the first patch, which provides both consistency in
> > interface and configuration.
> 
> We shall do out best to distribute info to places where it belongs.
> A much better approch would be to move all ext2 + ext3 stuff out in
> their respective directories.
> When modifying xfs (or ext2,ext3) no files outside their respective
> directories should in need to be touched - this would just impose
> additional burden doing parrallel development.

OK, I agree.

> 
> About your modifications:
> 
> Skipping the menu part is OK.
> While you are modifying Kconfig in xfs/ put a
> 
> if XFS_FS
> ...
> endif
> 
> around all config options expcept the one defining the XFS_FS option.
> This will fix menu identing.

Thanks for pointing this out. But the patch I posted is fair enough.
It just move one menu item around, and change nothing else. Are you
happy with it?

regards,
aq

  reply	other threads:[~2005-04-30  2:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-28  7:55 [PATCH] fs/Kconfig: more consistent configuration of XFS aq
2005-04-28  8:05 ` Chris Wedgwood
2005-04-28  8:09 ` Christoph Hellwig
2005-04-28  8:38   ` aq
2005-04-28  8:39     ` Christoph Hellwig
2005-04-28  9:21       ` aq
2005-04-29 21:28         ` Sam Ravnborg
2005-04-30  2:02           ` aq [this message]
2005-04-30  6:09             ` Sam Ravnborg
2005-05-01 11:26               ` aq

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9cde8bff05042919025d077eb1@mail.gmail.com \
    --to=aquynh@gmail.com \
    --cc=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox