Re: [PATCH v3 01/10] fsdax: Factor helpers to simplify dax fault code

Ritesh Harjani
2021-03-23T15:34:55Z

On 3/19/21 7:22 AM, Shiyang Ruan wrote:
> The dax page fault code is too long and a bit difficult to read. And it
> is hard to understand when we trying to add new features. Some of the
> PTE/PMD codes have similar logic. So, factor them as helper functions to
> simplify the code.
>
> Signed-off-by: Shiyang Ruan <ruansy.fnst@fujitsu.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/dax.c | 152 ++++++++++++++++++++++++++++++-------------------------
> 1 file changed, 84 insertions(+), 68 deletions(-)
>

Refactoring & the changes looks good to me.
Feel free to add.

Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>