From: Violet <violet@atl.tools>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] arm64: dts: qcom: add initial support for Samsung Galaxy S22
Date: Tue, 29 Jul 2025 11:46:00 +0000 [thread overview]
Message-ID: <9d13d012-8b10-4094-bea0-b85e799ff0c5@atl.tools> (raw)
In-Reply-To: <1ca25402-8f57-468c-b4d5-7b52f526ab28@oss.qualcomm.com>
On 7/17/25 20:19, Konrad Dybcio wrote:
> On 7/17/25 1:17 AM, Violet wrote:
>> Add new device support for the Samsung Galaxy S22 (SM-S901E) phone
>>
>> What works:
>> - SimpleFB
>> - USB
>>
>> Signed-off-by: Violet <violet@atl.tools>
>> ---
> [...]
>
>> +&tlmm {
>> + gpio-reserved-ranges = <36 4>, <50 1>;
> Do you know what these are connected to?
>
> We tend to document it, see e.g. x1-crd.dtsi
>
>> +};
>> +
>> +&usb_1 {
>> + /* USB 2.0 only */
>> + qcom,select-utmi-as-pipe-clk;
> Is that a hardware limitation? I thought these phones had the necessary
> pins connected (for DeX)..
>
>> + status = "okay";
> A newline before 'status' is good practice, file-wide
>
> Konrad
Thank you, I'll fix these issues on the next patchset. Indeed it is not a
hardware limitation, I just kept it USB 2.0 for now to avoid any
potential issues with 3.0.
next prev parent reply other threads:[~2025-07-29 11:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 23:17 [PATCH v6 0/2] arm64: dts: qcom: add initial support for Samsung Galaxy S22 Violet
2025-07-16 23:17 ` [PATCH v6 1/2] dt-bindings: arm: qcom: document r0q board binding Violet
2025-07-17 14:26 ` Krzysztof Kozlowski
2025-07-16 23:17 ` [PATCH v6 2/2] arm64: dts: qcom: add initial support for Samsung Galaxy S22 Violet
2025-07-17 14:26 ` Krzysztof Kozlowski
2025-07-17 20:19 ` Konrad Dybcio
2025-07-29 11:46 ` Violet [this message]
2025-07-17 6:16 ` [PATCH v6 0/2] " Krzysztof Kozlowski
2025-07-17 15:56 ` Rob Herring (Arm)
2025-07-30 9:21 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d13d012-8b10-4094-bea0-b85e799ff0c5@atl.tools \
--to=violet@atl.tools \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).