From: James Bottomley <jejb@linux.ibm.com>
To: Markus Elfring <Markus.Elfring@web.de>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: ses: Move a label in ses_enclosure_data_process()
Date: Fri, 29 Dec 2023 12:21:58 -0500 [thread overview]
Message-ID: <9d24844f30604f969ac10da456801f594ce72f2d.camel@linux.ibm.com> (raw)
In-Reply-To: <4616e325-e313-4078-9788-dd1e6e51b9e0@web.de>
On Thu, 2023-12-28 at 15:48 +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 28 Dec 2023 15:38:09 +0100
>
> The kfree() function was called in up to three cases by
> the ses_enclosure_data_process() function during error handling
> even if the passed variable contained a null pointer.
> This issue was detected by using the Coccinelle software.
Why is this an issue? The whole point of having kfree(NULL) be a nop
is so we don't have to special case the free path. The reason we do
that is because multiple special case paths through code leads to more
complex control flows and more potential bugs. If coccinelle suddenly
thinks this is a problem, it's coccinelle that needs fixing.
James
next prev parent reply other threads:[~2023-12-29 17:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 14:48 [PATCH] scsi: ses: Move a label in ses_enclosure_data_process() Markus Elfring
2023-12-29 17:21 ` James Bottomley [this message]
2023-12-29 17:29 ` Julia Lawall
2023-12-30 7:04 ` Markus Elfring
2023-12-30 12:41 ` James Bottomley
2023-12-30 13:36 ` Markus Elfring
2023-12-30 13:45 ` James Bottomley
2023-12-30 14:25 ` Markus Elfring
2023-12-31 14:07 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d24844f30604f969ac10da456801f594ce72f2d.camel@linux.ibm.com \
--to=jejb@linux.ibm.com \
--cc=Markus.Elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox