From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04D421A3164 for ; Tue, 18 Nov 2025 00:41:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763426470; cv=none; b=oQwyLm7Xp8CLitBNZ6oXT9x2KRKDBgs1HNuDIlHQw1Dsh7VxmiWYOjcpUhblKJ3oRTU5LtiXaki0BGDdgi/it5D3YHXmSoDjY9h3w3Q8QMwrtunKprX1J3JXw0BOqOfBVu3vtK1YTP5JtB9gWqrJeR3tDkAmkW9G/FCcOcDIruU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763426470; c=relaxed/simple; bh=d8c6RDiSUMuz5uXTP6tPYaBpD48u1FhU9bov2/C+B6w=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=ZjBTK4oeMnIdUZPHHjEdr4RQUibldw7hNl4CHOSSKeVkAx0Zdb4HpebNv+X6ER8E1SUJEWUERXLSI8bEBTz4dCvoUmsolrmNO3vjOFl+XdZdcNNDPnjMTcVmC70BM0/Sn+BD1KrxKNtCgqsEKNxQBTr+0jGrSmujmfe/4ZSsOwA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DRosOGtk; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DRosOGtk" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-7ba55660769so3184139b3a.1 for ; Mon, 17 Nov 2025 16:41:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763426468; x=1764031268; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=bkBaYmn0PwVoW+xjzEnmWu4VJvyj/VSjPE0mhzoh32I=; b=DRosOGtk3M2rg5097Bo6VGHeVsDEqcspkKjlhmJdieiFtBxH5pcGuQfPlbOVbfIwrh 2XcBqTAC4VWHx3WqWXcNWXWLusHHixjiYvf4GNDPZ9v5osCicOn8HyvsESXAe/qZHMSP Ca5f8D1WFikU1XOn78zfcF7FaZ8ZOM6QPHsdRe/e0y+pzexphmyXD5VxGTcwV/AiS2wE I4Xx2R5GCqvmHSHDP8COP6OkUKaMhlDgblTucmRetdsXRxAPqE+kypCQyOLVwgcZxS5T 1zx17IkoflmQo96QFpTXXTTBRwZiFE7alQXrsGC+Y1lDL8xjdWLcOvsaa/3m2XXw6m/p Mlgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763426468; x=1764031268; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bkBaYmn0PwVoW+xjzEnmWu4VJvyj/VSjPE0mhzoh32I=; b=HUiDC5/A8pt1HzRD9wboyothraxTuu+Y6mO63ww0tV6x2DZrfOtVPSpPILfq240G0Y /WV2cpFK1yoqAinAVuNtPNJ/JI7DC/ggXW5OGxdkd+2dU2E7fQ4hTjfoLNh28dnJ8Bvs AA762AQodvvtY+a0w/sOGuf565dfXIm3r69LP6UKnIw+FtxGBeAgu2lI1/aL0t1N4bOY 35eQUewURJ0wqnGoCHzZx8ZrRiZXL0iODJR37ktYtMDbIRDxPvxHIKewjfroO6p7GqYx 4rxe8cy3coy0Zj5biZ/iya1BFvjvav/uSBpgcrnklfJETQWZ5f7mLYVCpsUvtOaP4YMT vOOw== X-Gm-Message-State: AOJu0YyUXuE4leq8fjY/6WD1Bjc3CVmkMLV592m/WaJa6ybpRiMjd2rP r2WelK9b/mwAsxVpWIQC5+tgl6QvRaOApMdil1g43zJV8KiQpTRDhBgf X-Gm-Gg: ASbGnctueYg9GXE5J1g9u3J4c8JSBFpKksgjUM0p1mnVax70Txahz69fA23sIW3Q8OQ nrzuNctDw5H1W3/8/FT4+RmLcVOp1M4nVIULJWnzD5MFkixM6kCjsocnvPSyYHF23dk2QMErSJZ 6zyAeAGTrpz2YlKmCVQRXmN9j9zA6I5d8QNTyXA1TpyuGVTkaS2x9CnUd+i7ivwoRuQcB8bWdKu k4W9YD1sbUyNSjhHgFVoMXPEvCJJ8A4SrySD7PFcAYTmT6x+ltso8zs5nlULZLtM1paSwYfkiKi W8xDE4NHS11MjXq6JKGBhO/mAjEDtM4V75FmXgFVU7fcOCf5OG+kAatcMc3rXT3oLovcXdKV2Gy RNH3S3o1f0hAH52EWBOCiErKq4mdIfX/GoQCgtS0eU4HpWCYtN+XTfxQJpRGtvsAewvLWju6fyq qUIYZPQ4SP9n1+Skkr X-Google-Smtp-Source: AGHT+IEM/yLUwXJP7N3P3WF56yw/23PQR0e+8cuU/GNlUwJVkJQrhfhISkf2JbYKy6Ip2DaGzPuglw== X-Received: by 2002:a05:6a00:14c9:b0:7b2:1fb0:6da0 with SMTP id d2e1a72fcca58-7ba3c6729c3mr17383406b3a.28.1763426468130; Mon, 17 Nov 2025 16:41:08 -0800 (PST) Received: from [192.168.0.233] ([159.196.5.243]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7b9250cd969sm14475738b3a.23.2025.11.17.16.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Nov 2025 16:41:07 -0800 (PST) Message-ID: <9d351634fd1324ed00830d7af1d0406dfffa261d.camel@gmail.com> Subject: Re: [PATCH v3 2/4] nvmet-tcp: Don't free SQ on authentication success From: Wilfred Mallawa To: alistair23@gmail.com, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, hare@suse.de, kch@nvidia.com, linux-nvme@lists.infradead.org Cc: linux-kernel@vger.kernel.org, Alistair Francis Date: Tue, 18 Nov 2025 10:41:02 +1000 In-Reply-To: <20251114045850.1898865-3-alistair.francis@wdc.com> References: <20251114045850.1898865-1-alistair.francis@wdc.com> <20251114045850.1898865-3-alistair.francis@wdc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.1 (3.58.1-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2025-11-14 at 14:58 +1000, alistair23@gmail.com wrote: > From: Alistair Francis >=20 > Curently after the host sends a REPLACETLSPSK we free the TLS keys as > part of calling nvmet_auth_sq_free() on success. This means when the > host sends a follow up REPLACETLSPSK we return CONCAT_MISMATCH as the > check for !nvmet_queue_tls_keyid(req->sq) fails. >=20 > This patch ensures we don't free the TLS key on success as we might > need > it again in the future. >=20 > Signed-off-by: Alistair Francis > Reviewed-by: Christoph Hellwig > Reviewed-by: Hannes Reinecke > --- > v3: > =C2=A0- No change > v2: > =C2=A0- Don't call nvmet_auth_sq_free() in nvmet_execute_auth_send() > either >=20 > =C2=A0drivers/nvme/target/fabrics-cmd-auth.c | 9 ++++----- > =C2=A01 file changed, 4 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/nvme/target/fabrics-cmd-auth.c > b/drivers/nvme/target/fabrics-cmd-auth.c > index 2e828f7717ad..0cd722ebfa75 100644 > --- a/drivers/nvme/target/fabrics-cmd-auth.c > +++ b/drivers/nvme/target/fabrics-cmd-auth.c > @@ -397,9 +397,10 @@ void nvmet_execute_auth_send(struct nvmet_req > *req) > =C2=A0 goto complete; > =C2=A0 } > =C2=A0 /* Final states, clear up variables */ > - nvmet_auth_sq_free(req->sq); > - if (req->sq->dhchap_step =3D=3D > NVME_AUTH_DHCHAP_MESSAGE_FAILURE2) > + if (req->sq->dhchap_step =3D=3D > NVME_AUTH_DHCHAP_MESSAGE_FAILURE2) { > + nvmet_auth_sq_free(req->sq); > =C2=A0 nvmet_ctrl_fatal_error(ctrl); > + } > =C2=A0 > =C2=A0complete: > =C2=A0 nvmet_req_complete(req, status); > @@ -575,9 +576,7 @@ void nvmet_execute_auth_receive(struct nvmet_req > *req) > =C2=A0 status =3D nvmet_copy_to_sgl(req, 0, d, al); > =C2=A0 kfree(d); > =C2=A0done: > - if (req->sq->dhchap_step =3D=3D > NVME_AUTH_DHCHAP_MESSAGE_SUCCESS2) > - nvmet_auth_sq_free(req->sq); > - else if (req->sq->dhchap_step =3D=3D > NVME_AUTH_DHCHAP_MESSAGE_FAILURE1) { > + if (req->sq->dhchap_step =3D=3D > NVME_AUTH_DHCHAP_MESSAGE_FAILURE1) { > =C2=A0 nvmet_auth_sq_free(req->sq); > =C2=A0 nvmet_ctrl_fatal_error(ctrl); > =C2=A0 } Reviewed-by: Wilfred Mallawa Wilfred