public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Suzuki K Poulose <suzuki.poulose@arm.com>
To: Arnd Bergmann <arnd@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Marc Zyngier <maz@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	David Brazdil <dbrazdil@google.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap
Date: Fri, 29 Oct 2021 14:31:23 +0100	[thread overview]
Message-ID: <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> (raw)
In-Reply-To: <20211029113023.760421-1-arnd@kernel.org>

Hi Arnd

Thanks for the fix.

On 29/10/2021 12:30, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> It's now used in a coresight driver that can be a loadable module:
> 
> ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined!
> 
> Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling")

Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Tested-by: Suzuki K Poulose <suzuki.poulose@arm.com>

Will, Catalin, Mathieu,

Do you have a preference on how this fix can be pulled in ? This may
be safe to go via coresight tree if it is not too late. Otherwise,
it could go via the arm64 tree.

Suzuki

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Not sure if we actually want this to be exported, this is my local
> workaround for the randconfig build bot.
> ---
>   arch/arm64/kernel/cpufeature.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> index ecbdff795f5e..beccbcfa7391 100644
> --- a/arch/arm64/kernel/cpufeature.c
> +++ b/arch/arm64/kernel/cpufeature.c
> @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n)
>   
>   	return false;
>   }
> +EXPORT_SYMBOL(this_cpu_has_cap);
>   
>   /*
>    * This helper function is used in a narrow window when,
> 


  reply	other threads:[~2021-10-29 13:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29 11:30 [PATCH] [RFC] arm64: export this_cpu_has_cap Arnd Bergmann
2021-10-29 13:31 ` Suzuki K Poulose [this message]
2021-10-29 15:12   ` Mathieu Poirier
2021-10-29 18:06   ` Catalin Marinas
2021-11-01  9:01     ` Will Deacon
2021-11-01  9:34       ` Suzuki K Poulose
2021-11-01  9:40         ` Will Deacon
2021-11-01  9:52           ` Suzuki K Poulose
2021-11-01 11:13             ` Greg Kroah-Hartman
2021-11-01 15:32               ` Mathieu Poirier
2021-11-02 23:16     ` Suzuki K Poulose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com \
    --to=suzuki.poulose@arm.com \
    --cc=anshuman.khandual@arm.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dbrazdil@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=maz@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox