Re: [PATCH 1/2] dt-bindings: display: panel: Add Visionox R66451 AMOLED DSI panel bindings

Marijn Suijten
2023-05-21T10:54:37Z

On 2023-05-16 13:20:30, Jessica Zhang wrote:
> Document the 1080x2340 Visionox R66451 AMOLED DSI panel bindings
>
> Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
> ---
> .../bindings/display/panel/visionox,r66451.yaml | 59 ++++++++++++++++++++++
> 1 file changed, 59 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/visionox,r66451.yaml b/Documentation/devicetree/bindings/display/panel/visionox,r66451.yaml
> new file mode 100644
> index 000000000000..6ba323683921
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/visionox,r66451.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: GPL-2.0-only or BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/visionox,r66451.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Visionox R66451 AMOLED DSI Panel
> +
> +maintainers:
> + - Jessica Zhang <quic_jesszhan@quicinc.com>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: visionox,r66451
> +
> + reg:
> + maxItems: 1
> + description: DSI virtual channel
> +
> + vddio-supply: true
> + vdd-supply: true
> + port: true
> + reset-gpios: true

Normally for cmd-mode panels there is also a `disp-te` pin which is
optionally registered in dsi_host.c as GPIOD_IN, but on **ALL** my Sony
phones this breaks vsync (as in: mdp5 stops receiving the interrupt, but
we can see disp-te in /proc/interrupts then).

- Marijn

> +additionalProperties: false
> +
> +required:
> + - compatible
> + - reg
> + - vddio-supply
> + - vdd-supply
> + - reset-gpios
> + - port
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + panel@0 {
> + compatible = "visionox,r66451";
> + reg = <0>;
> + vddio-supply = <&vreg_l12c_1p8>;
> + vdd-supply = <&vreg_l13c_3p0>;
> +
> + reset-gpios = <&tlmm 24 GPIO_ACTIVE_LOW>;
> +
> + port {
> + panel0_in: endpoint {
> + remote-endpoint = <&dsi0_out>;
> + };
> + };
> + };
> + };
> +...
>
> --
> 2.40.1
>