From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759068AbdENPSW (ORCPT ); Sun, 14 May 2017 11:18:22 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:46830 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758933AbdENPST (ORCPT ); Sun, 14 May 2017 11:18:19 -0400 Subject: Re: [PATCH v2] iio:ad5064: Add support for ltc2633 and similar devices To: Lars-Peter Clausen , Mike Looijmans , linux-iio@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Michael.Hennerich@analog.com, knaack.h@gmx.de, pmeerw@pmeerw.net References: <1493199875-11912-1-git-send-email-mike.looijmans@topic.nl> <646b634f-c0ad-f39c-a395-02461f5e8352@metafoo.de> <1494228384-28786-1-git-send-email-mike.looijmans@topic.nl> From: Jonathan Cameron Message-ID: <9da01a92-e8bd-cadb-86bc-b2ef2e477bf8@kernel.org> Date: Sun, 14 May 2017 16:18:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-GH Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/17 10:12, Lars-Peter Clausen wrote: > On 05/08/2017 09:26 AM, Mike Looijmans wrote: >> The Linear Technology LTC2631, LTC2633 and LTC2635 are very similar >> to the AD5064 device, in particular the LTC2627. >> >> This patch adds support for those devices. Only the LTC2633 has been >> tested, which is the 2-channel variant. The LTC2631 is the 1-channel, >> and the LTC2635 the 4-channel version. The actual DAC resolution depends >> on the exact chip type and can be 12, 10 or 8 bits, using the upper bits >> so this has no effect on the register map. The internal reference is set >> to 2.5V on "L" versions, and it's 4.096V for "H" versions. >> >> Datasheets: >> LTC2631: http://www.linear.com/docs/26553 >> LTC2633: http://www.linear.com/docs/39529 >> LTC2635: http://www.linear.com/docs/28754 >> >> Signed-off-by: Mike Looijmans > > Reviewed-by: Lars-Peter Clausen > > Thanks for reworking the patch. > Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan