From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5449F3C73F8; Fri, 10 Apr 2026 13:45:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775828758; cv=none; b=Xed/kDn67CI1+j7JwllnwA1P75x9IJiqzK3l5IhiRd1R3UVTDP8HsvILHxsVhzy3U/k3K56MXKWZTSkAO7184dAOVGaOJbWFwNroMg0TGY8fxMfW6oedxWgZ7b7IrAd2k4Zqz9rnZZSnA/DcaVcrf4e+SE8Ef0Ibz2GrYCqQB4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775828758; c=relaxed/simple; bh=XhwVNk7AmxnQFYYbofWW0xn2GGcCMLifpnTZm0hI0iw=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=UDfpEL6erpdFyhfTsT/TSVh30p3FeXj7qe9P2GAmSB12jWnHJBbPuFylcmFcGFNV0D6lpwzb0b7YFAzECmcuPxO9NgLjBRPEgpzNvDdbzv2Hypch8ROTB8IwA4JwL6Ss5wa2kySvZlwjhxWQD7W1jfiCyHvSMBxTX6A7hMxi/u0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=YJ3HbNt9; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YJ3HbNt9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1775828758; x=1807364758; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=XhwVNk7AmxnQFYYbofWW0xn2GGcCMLifpnTZm0hI0iw=; b=YJ3HbNt9KqVB6c72n0p3I8tV+eLDZ8Pyvh5wkY5xQ80nLKZnDJVlBLVF /hWAQZuWIDsV0WzZ3NafaV6PbRU1gbqE03bRNkaV148sKfbtEAW/igX0F p3HosWplFkRdknQELLo40Q+VWWm6s0SkUOr9cB6gj0v7QrMlkl8j1EP6B QEPe32p1VrBic6WVONIBTy+AhKGOcgJLSEVoXNFsHqpkeFVJRhKHh4Gpb EprtxrG4CNlyH98+XlztwbJRkUni6GBzIuFoWPlIOvUPOQzONN1aV4owx gK5Jt8h5EaRkh/0/onvfP49+HmHEo3oJPFp2j6q9ni6hd9s9zFXoDX4P+ Q==; X-CSE-ConnectionGUID: W3a5tcAAR4SmhhFO5OGbew== X-CSE-MsgGUID: NE2Q/sTERymqCkH53yD8ig== X-IronPort-AV: E=McAfee;i="6800,10657,11755"; a="88229167" X-IronPort-AV: E=Sophos;i="6.23,171,1770624000"; d="scan'208";a="88229167" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2026 06:45:56 -0700 X-CSE-ConnectionGUID: 5EGNTPxSQP+GmiqHTb7hcA== X-CSE-MsgGUID: poU0WXXBR3aVBOf3UOJDiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,171,1770624000"; d="scan'208";a="225932507" Received: from blu2-mobl.ccr.corp.intel.com (HELO [10.124.248.249]) ([10.124.248.249]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Apr 2026 06:45:46 -0700 Message-ID: <9db9515b-08e8-47bd-aced-206ac183195a@linux.intel.com> Date: Fri, 10 Apr 2026 21:45:43 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: baolu.lu@linux.intel.com, x86@kernel.org, iommu@lists.linux.dev, Arnd Bergmann , Michael Grzeschik , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Herbert Xu , linux-crypto@vger.kernel.org, Vlastimil Babka , linux-mm@kvack.org, David Woodhouse , Bernie Thompson , linux-fbdev@vger.kernel.org, Theodore Tso , linux-ext4@vger.kernel.org, Andrew Morton , Uladzislau Rezki , Marco Elver , Dmitry Vyukov , kasan-dev@googlegroups.com, Andrey Ryabinin , Thomas Sailer , linux-hams@vger.kernel.org, "Jason A. Donenfeld" , Richard Henderson , linux-alpha@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org, Catalin Marinas , Huacai Chen , loongarch@lists.linux.dev, Geert Uytterhoeven , linux-m68k@lists.linux-m68k.org, Dinh Nguyen , Jonas Bonn , linux-openrisc@vger.kernel.org, Helge Deller , linux-parisc@vger.kernel.org, Michael Ellerman , linuxppc-dev@lists.ozlabs.org, Paul Walmsley , linux-riscv@lists.infradead.org, Heiko Carstens , linux-s390@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org Subject: Re: [patch 09/38] iommu/vt-d: Use sched_clock() instead of get_cycles() To: Thomas Gleixner , LKML References: <20260410120044.031381086@kernel.org> <20260410120318.187521447@kernel.org> Content-Language: en-US From: Baolu Lu In-Reply-To: <20260410120318.187521447@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/10/2026 8:19 PM, Thomas Gleixner wrote: > Calculating the timeout from get_cycles() is a historical leftover without > any functional requirement. > > Use ktime_get() instead. The subject line says "Use sched_clock() ...", but the implementation actually uses ktime_get(). Is it a typo or anything I misunderstood? Other parts look good to me, Reviewed-by: Lu Baolu > > Signed-off-by: Thomas Gleixner > Cc:x86@kernel.org > Cc: Lu Baolu > Cc:iommu@lists.linux.dev > --- > arch/x86/include/asm/iommu.h | 3 --- > drivers/iommu/intel/dmar.c | 4 ++-- > drivers/iommu/intel/iommu.h | 8 ++++++-- > 3 files changed, 8 insertions(+), 7 deletions(-) Thanks, baolu