From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FA3742A787 for ; Fri, 10 Jul 2026 12:51:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783687871; cv=none; b=PdrBqHNZl2YcEao71KIaXbha+Y+mm2OhDSly4pdziXWmLyD7SlcnDIGdJg58j1iwKSBV+20dkqcJiB3NOLDk8/BtDQ0lWtIbMka4UTKX1Nnxmgun70tslqWNE3BvZeKTlv5wnilbAgr9gXtqGNV+GqWcppL0MbSg6duOwHKBpyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783687871; c=relaxed/simple; bh=6ikcLdHgMP7Ta1QNKMU8D2+OrlHjityLyO+ugcqC5/s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=htr79bf7OcxznO3snlIEcJulV6N3hdJ9j6Z8ZBk7ESt2DBo0WKNOD8F62MsYg89aNZbo+jzNvC5NPit1x7cD2UYITzP5kyVqc/f5oqnwvicgkvNcvcCeyzBoGHRfg5MmF5c8Y/AFXWwTElIirRD4jWE4htMnAHDrlTsWU0jm0j4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=RHGwl9Px; arc=none smtp.client-ip=209.85.219.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="RHGwl9Px" Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-8fcc43c48f7so7151816d6.2 for ; Fri, 10 Jul 2026 05:51:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1783687868; x=1784292668; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RI31gw/Ag7VVxVHoPD2L4lb5ga+FSsjQx8Z6xYz3UlU=; b=RHGwl9PxJfLoEKUCb1jF8TRRS0WemZQYky3/4iykJu5954iY/INB4n+vvW/Tkjw8tJ weMJ9MSjZEjdN1OGrQpmMJFaZ9f3qSKMZPLiTRkkvXb7habCG4ro06hRGfu5CeaRwIqA FdmEsy/EGmuCjkAS8gBYXbEUqiUOlfyEuHCUVpKBe2lh0+39HDv40+cNd4KPzxFA+UXe TtDeoTp5t1XBOf1uvafmTKzE1emDz6YujPGdqHsBQTmYCF8jvPBjl/DzZMBeUnwH42sT Y44wJOerLw6m4Bq8oNa+N5NcWadfIL42T7LVhNsdycnC9iw+/aXnvz3MHKZUbMxjSfEZ xUWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783687868; x=1784292668; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RI31gw/Ag7VVxVHoPD2L4lb5ga+FSsjQx8Z6xYz3UlU=; b=q0ocipgAHj8un+FD19BXRyg47cTzznK/m9TjZSyuevvIl1Qp3PIg3qQAIDKvLxjy8Y Uh6uqjbZv8f8bBgi6aFkFoRjkbUo4C3YezFIDGKNlBbqDGN1Rau6YbG0jdWG0747yUGp mOcoVXk2Dcmp8znkQExIBREDVkUN4oyGkiybnAHaEQDZjcdWlotlB5LCrKHJb39ib3Ma 2aUsoclEUs3C3XK48R1PZ8P22ATDH8IjcTDGZmh33eImt7w39c0zK7gjXtyIhw8/DDIP Vin9ijPLz3049UB6t9z9BXH+Lsq5BJpPh3WTiNcw4KqbJjH/YAF8UUbluk7LcEehr6xO DGMw== X-Forwarded-Encrypted: i=1; AHgh+Ro9NIC36rngrp5W0yA3i7sifUiEqbkAhxIP2RnGiPfsJ0BjQAEfUZLjzkZjWevy8WP5k2B2EzTV9GWIuLg=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2YvWauSJBzLDQdpW8utYZa4sxCxP8NWZVjl9MJPtX7qeBFxNr gOOBR4LSqw20FbvFMnuACDDghAl9wC/yoC78Cwx4cP/fFSq1G9YavzNXtkaaq9DnmX8= X-Gm-Gg: AfdE7clwdWHcizkDOx2M5fLDtcskcDLnxfKYnJMpLxMbcngEwQFR4OYCAkpT0bUYVcW Quc74NXIomg3Xfbcb2oLPAMJZLMTSB0HrHIv6jvGYq/Su0YvJ3QED9EkI/wfFZWsLYeTaQohCqv jG28q8LXNMsRhKIep/cLAroEsTRoy4GF5POnCqCfk+lTZjFtVsvF6QKruSj/e9tN9xfJL+7dwCs Fzz7P8vsFgE7Mrzxa1V8+W+/eUjSrqg1bW6qrBuOQV6z2qs09mBHsYqi60Td2KRH6BLyl/RKeIo pllxLWofokUGiNfwc6m8ORBCN76sg0XdvrWulBLqC1rUbUk67szwSjVK9ApVufrZxkMxzcpgR/q RJvwzz7kF8wOKlj0eZIRX+m9zKNYDtfHPeIRpgntnjCf0WC+fEECBUqzh8wSoax1i0z3d67xXW5 cGIZWyYycP5f2s X-Received: by 2002:a05:6214:2487:b0:8ce:aace:eaf7 with SMTP id 6a1803df08f44-8fec246fde7mr144215156d6.39.1783687868337; Fri, 10 Jul 2026 05:51:08 -0700 (PDT) Received: from [172.22.22.28] ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd80fd82csm40299876d6.35.2026.07.10.05.51.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 05:51:07 -0700 (PDT) Message-ID: <9de024d9-c7a8-4291-a79d-83acc77b261d@riscstar.com> Date: Fri, 10 Jul 2026 07:51:05 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/6] PCI: spacemit-k1: Add multiple PHY handles support To: Andy Shevchenko , Inochi Amaoto Cc: Jingoo Han , Manivannan Sadhasivam , Bjorn Helgaas , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Christian Bruel , Frank Li , Nam Cao , Qiang Yu , Krishna Chaitanya Chundru , Xincheng Zhang , Siddharth Vadapalli , Vidya Sagar , Neil Armstrong , Gustavo Pimentel , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, Yixun Lan , Longbin Li References: <20260709040027.958400-1-inochiama@gmail.com> <20260709040027.958400-3-inochiama@gmail.com> Content-Language: en-US From: Alex Elder In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/9/26 2:16 AM, Andy Shevchenko wrote: >> + if (IS_ERR(k1->phy[i])) { >> + if (PTR_ERR(k1->phy[i]) == -ENODEV) >> + break; >> + >> + return PTR_ERR(k1->phy[i]); >> + } > if (PTR_ERR(k1->phy[i]) == -ENODEV) > break; > if (IS_ERR(k1->phy[i])) > return PTR_ERR(k1->phy[i]); I'm not sure this is a huge improvement. Checking IS_ERR() before using PTR_ERR() is comforting (a little along the lines of the other issue you mentioned--assigning a result before checking for an error). Anyway, it's a little bit of an ugly construct no matter how you do it. Here's another possible way to do it. k1->phy[i] = devm_of_phy_get_by_index(dev, node, i); if (!IS_ERR(k1->phy[i])) continue; ret = PTR_ERR(k1->phy[i]); if (ret == -ENODEV) break; return ret; -Alex