From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99DF078F29 for ; Mon, 23 Feb 2026 04:11:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771819872; cv=none; b=XYrfeaf7ECbHIsicQzF2HDFW9ffTByDfXIyQsCHCbWevKZmWd4fZR0LfBTkTEHA4yXikVzwCOHmrPGM5mv0gz7xs7coKwH1az6VYASJX6OlPN+0p8xXdDca7lhx+Z77pQq1HUzdbteFYx4jyf/LRHAjXyH2cdwTioVDOaFd5lD8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771819872; c=relaxed/simple; bh=pK2mrrtPuRNmvsqeRdkmGxg4hvXswhtTttTGwKwnYvY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Yl2Uf6XfSi8meZolkjlykjxeIMPhLjcWPFY5C4MryqH1HNfP57ZEruYyw9TAepB8nHHKCbXCSHowwtW9eP5z4SFgfyWgkvl1p7w8fpwJ+K6k7cKr1PGeYp9o/mmNxZVC2MmMJpIAv5R4/OMsPvsKB0kugvvjr3znQ+bfYThZhtw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HpvXHvmh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XByqp1vE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HpvXHvmh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XByqp1vE" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61MLrA652121043 for ; Mon, 23 Feb 2026 04:11:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= yvxeIuAz4elwHbRZzch3j8yGiACxyiE0IXv3v/wGlrc=; b=HpvXHvmhN8XLm6Jn lTasXuj+d7GTZi49/6A+kqdbNUWT2oHVeyYq5Ni15FgwzyyiqRxOxzrby6JNUgVQ b009kuKQFBuNIQefGdkVPV4V2Lpgnd1OQdhvZXnBaIMX0nYzrN+zn8LiKwdY99ej hfpL+Xb60TXBhlek1091w1eELHh0MMvHCtroXo/GGN148DOks1/uhOkS7tdoOaIC sEeRLrMBPKCu173Eevqpe0wpN3ikwJu2XnEMkU+7CWwyMp6Uh6V2capuAS9nuosc vtRzufIxmgXIpUHYuK/jEutRFxXiHXExVf31bn/gnX/dOmna9WnsCUWo1RihVDrj 3w4QjA== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cf5vuk8xk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Feb 2026 04:11:10 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35464d7c539so3743522a91.0 for ; Sun, 22 Feb 2026 20:11:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771819869; x=1772424669; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yvxeIuAz4elwHbRZzch3j8yGiACxyiE0IXv3v/wGlrc=; b=XByqp1vEaMRxeYdAIiVo7f897lQV8SuYoZm3FsbEbVm3E1MKyRDsjW682ZiJ3pFcM4 smeibEFhn8enGNVBkYVVur583B5heOGnSGyCqIe+v5DMsZf/7HzD2/gn3oqOT65XknWs tOHRjF4M9q4799v9Hbmsw3vOisSs4WECDu5FnI23DquuNf+/APdyalFjfK+nfqQSJO10 Ff3f3kP6/Masi9qzCw3xHtMCFHZOQdkDzS8FhSlFhfA+5HBHja1piRrKizMocX6p2GBQ zcM32W3CDxLEgd8K4zsJvCXs9uK7ER8VwMDOaIk0s/gEo40JddudjdValP37FUGdKScE zAIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771819869; x=1772424669; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yvxeIuAz4elwHbRZzch3j8yGiACxyiE0IXv3v/wGlrc=; b=G8kP3k6W79sEclCzyHFKHMhOE65N+S+q2TE4WpwW9GQjmADm87OXAERvCSPDv84e+Z OAxC74fWVVrH5OitG90ui+7Km6q6SEwRjJpZMEYwBWuO5Zcb+Sorslq2w8pj4yMp46ex f9ZYCu7p9LCD+v540BLygBkOLDU5Nazdv7CG253rc556eoRNweN9pk/Wl7XCxfEFpDrP 8Kf1TjGyMaKHMdBu+amLayD4+7UwfjIexd9UxOAFA+qiaFxhhU1Y/kXXimIIIN8uxtvx dL94vCySF02bsFz9Z2c0DggV21dy0JdDB5oX5+ZLhfGnqPd/TdK4uei0A4tCSPv+4Uqy 2V5Q== X-Forwarded-Encrypted: i=1; AJvYcCUmaiqHJsvEcOqY6s7dPnUcf62eU+zWYqie0SHuXaVyojJqs+KwzhOJ7H5I6BdzyS1VOqdNhLMV/x9gN8E=@vger.kernel.org X-Gm-Message-State: AOJu0Yzu6PN0zePjFOxli/7BR54QvfetAUz9Y/4PE7tJN4A0RLuMLemY UuHO/bjVOPDcHjuUQctZ1wsCr1FN0TkmR1UgwooKuKfOcOL9ncCU9etrWX2Nz0OQ1sd3/ajs6WL e+Oj+sU1brcC6WTQWzzKkBNTthD4j7QgLCV+rlzu11FgNBSTM3DcsqrIr8IXiglE43bI= X-Gm-Gg: ATEYQzzx8COX0pq8THD6dOLvUSKfxsDAo9JAYwZzSTm5CIs4cGgfBGPJpkEQX/w16w2 kumVVBpm3ffv7vgjKC1BuAFFHs8D1WORUk7/6VDw5QIPyBpmDCY9C3rVKquYtXsGvu3jFzjoosT 12L7uX0aMzv6YX8iqomu9zLpwzQHTZAnhKAag2Wv0nCRYWp20t8c2JgLiwUCs1dxmFUG6Syegim /IXoCAjD4JaAVSh4SIEJm9YNaEwdhRcg/X2nBFehNlk1q8jzXIst82pBgsgk144IdPVzHaI9cr7 uop54T22SjeLX+a/LaX0FRKIKiF2cdBCdiQ6/O7easEp51F/Q53+S8cnb71eXMm9XX3TU34hMWt PrHQeO30yxMB4O5UBpnGrr7wvn+du12lwjXAMaBH3Tnv1Zv9WFZg= X-Received: by 2002:a17:90b:5687:b0:340:be44:dd0b with SMTP id 98e67ed59e1d1-358ae8f6728mr4987386a91.34.1771819869261; Sun, 22 Feb 2026 20:11:09 -0800 (PST) X-Received: by 2002:a17:90b:5687:b0:340:be44:dd0b with SMTP id 98e67ed59e1d1-358ae8f6728mr4987376a91.34.1771819868763; Sun, 22 Feb 2026 20:11:08 -0800 (PST) Received: from [10.217.198.242] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-358af93b2bdsm5386376a91.16.2026.02.22.20.11.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Feb 2026 20:11:08 -0800 (PST) Message-ID: <9defac59-ae8a-4658-ab38-dcb0559d9708@oss.qualcomm.com> Date: Mon, 23 Feb 2026 09:41:04 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: hamoa/x1: Fix TODO in system power domain node To: Daniel J Blueman , Konrad Dybcio Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, stable@kernel.org References: <20260221105245.19328-1-daniel@quora.org> Content-Language: en-US From: "Maulik Shah (mkshah)" In-Reply-To: <20260221105245.19328-1-daniel@quora.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=AL4GpdX7 c=1 sm=1 tr=0 ts=699bd35e cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=t9ty7G3lAAAA:8 a=Z6mox6vU0p-v88y-cpwA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=CsAS6f0m0zARWR-uHzm3:22 X-Proofpoint-GUID: MSYft1aSIcEB3ZF7rDrIJ59_4gErj8OL X-Proofpoint-ORIG-GUID: MSYft1aSIcEB3ZF7rDrIJ59_4gErj8OL X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjIzMDAzMyBTYWx0ZWRfX3ALUVZrQaXQk Ny/l0WUtWtccIjbdcQ682taurixL5QkWWRr/+qR0C4qlJ5u16sAW10gS3QmZqnXo3Z88LLoGDk1 TEJFOLyfCP/kzWz+BFV9CSPnea9Skld0v/IjMb7iLsCfP+K5uvGbZodiUcBloDI7Q4HnYZ4Yhc9 FbZatljxaBhu2+ipy+RSfc1VoOobc5wmBdHBpmlBUYpl88iTG/KGZSEXX00gP0wKbAx5hsX41Hv 7ex/2qjkACWhJVOFjaFULlzAVbpt/ngAykvMyjXG0YVnyjXRi1Cl7VGqiXuP28ibXGsj/+QwWNn L8+BYjo3xZ2ENXoF/FqfvmYLcy/uP+8yE+NDITELPVxDG03AN2bjfq1tDJykOVKjdARS9M3jUek sbOQDzjUmIBnKqbKSE1JYL1FadWNS4GCg/E4gTBdCKuJc9mPrH3bFDd7SjVywdT9aOQ+JIx4lAn p2GibLPmR2VigpdnTNw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_01,2026-02-20_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 impostorscore=0 phishscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 adultscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602230033 On 2/21/2026 4:21 PM, Daniel J Blueman wrote: > At present, designs based on the Qualcomm X1 Hamoa reference platform have an always-on system power domain since the OF node values aren't implement. Implemented. > > Fix this by using the CPU C4, cluster CL5 and system DRIPS parameters from the ACPI DSDT Windows uses, together with the Low Power Idle _LPI minimum residency of 9000us and wake latency of 5000us as exit latency. Finally, assume the entry latency is the difference of these two values. ACPI used 5000usec as total exit latency, with this change total exit latency will be 9000usec (sum of entry + exit). > > Tested on a Lenovo Yoga Slim 7x with Qualcomm X1E-80-100. > > Fixes: f33767e3cfa5 ("arm64: dts: qcom: x1e80100: Add missing system-wide PSCI power domain") Using this fixes tag, can make the change back ported to stable kernels without dependencies and may break the GPIO IRQs. Background: PDC monitors the wakeup capable IRQs during system wide low power state, hitting the system low power mode can break to wake via GPIO IRQs. The system-wide idle state was not added since the wakeup capable GPIO IRQs were not configured at PDC with 602cb14e310a ("pinctrl: qcom: x1e80100: Bypass PDC wakeup parent for now"). So IMO this fixes tag should be used instead of above with the changes to configure PDC to monitor GPIO wake ups. I have these changes to configure GPIO IRQs at PDC and enable back domain_ss3 idle state in my local tree, which i plan to post this week or next. Thanks, Maulik > Signed-off-by: Daniel J Blueman > --- > arch/arm64/boot/dts/qcom/hamoa.dtsi | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/hamoa.dtsi b/arch/arm64/boot/dts/qcom/hamoa.dtsi > index a17900eacb20..64338769bc85 100644 > --- a/arch/arm64/boot/dts/qcom/hamoa.dtsi > +++ b/arch/arm64/boot/dts/qcom/hamoa.dtsi > @@ -290,6 +290,14 @@ cluster_cl5: cluster-sleep-1 { > exit-latency-us = <4000>; > min-residency-us = <7000>; > }; > + > + domain_ss3: domain-sleep-0 { > + compatible = "domain-idle-state"; > + arm,psci-suspend-param = <0x0200c354>; > + entry-latency-us = <4000>; > + exit-latency-us = <5000>; > + min-residency-us = <9000>; > + }; > }; > }; > > @@ -448,7 +456,7 @@ cluster_pd2: power-domain-cpu-cluster2 { > > system_pd: power-domain-system { > #power-domain-cells = <0>; > - /* TODO: system-wide idle states */ > + domain-idle-states = <&domain_ss3>; > }; > }; >