From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6ABD817B418 for ; Mon, 11 May 2026 18:07:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778522871; cv=none; b=Hu++yz1pRwYcSPihnVLgojes37ax9/1K/ppOoeCyc4wwyOe79AxhXLIvDewV/k+uiAxc/Z3Y/2wuePnPS6pzOm5bHLeCNmaRJtuaZ+VkiPZo0FeEF4orF6hojgffO+RgkbhTEiQGyNfvCWb+4llFZMcM+O1BH9mwhfpuROU7/BA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778522871; c=relaxed/simple; bh=Y7181jF1bSs6LMnCapoKzcgBWoMTajIXSJ5pxwHBPRw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JZW5ocb9TM02QPEOqdGPboL220EaHI/TN/KiVr0pk825vljiWstWAZzUCzLRF50JmACvmDgBe+eg4dC5VFpFRmbDSDcEOsEgP07STHTa1ua928axEh6piSSeW2jgytUldKAG7N7VaU+WXqxA6w7tfa320OOgniHqXF5SRypM9ko= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jC0EGkgg; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jC0EGkgg" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14B2AC2BCB0; Mon, 11 May 2026 18:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778522871; bh=Y7181jF1bSs6LMnCapoKzcgBWoMTajIXSJ5pxwHBPRw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jC0EGkggvlYx6PmXezKzPi9NKvVbs12aG8LROPmIO3q/Fz6/TS98sKot9fcv+IxdY j9UsWqUlyI6ErX/7MXgDtd4tfNdNc4oxY4Qou1KxzZK3Y7uOYXDZrdjJPBb3uYdKEo BCfU0Yrp8W11XhQxdXGip242l0eDAvgoUXsppLlfL3Q8Y3Yb1IhwblWraD6cmeXljy QQ0BGP4zJLfFMulMldAhEuYaUQ1U8/2vT6fLtSP7nLWhqJoGgpYFHmM/jHQ7mYebQY 0LiBG+C3JTqqVoXMgU21ox7vbCgrnknCCEd7AEJsZ3taObmn976xEp/G7p7TT0x+U3 5b68M4i2Fbp6Q== Message-ID: <9df7caf5-fccf-40bf-b8c6-ef633ae44bff@kernel.org> Date: Mon, 11 May 2026 20:07:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 13/22] mm: rejig pageblock mask definitions Content-Language: en-US To: Brendan Jackman , Borislav Petkov , Dave Hansen , Peter Zijlstra , Andrew Morton , David Hildenbrand , Wei Xu , Johannes Weiner , Zi Yan , Lorenzo Stoakes Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, rppt@kernel.org, Sumit Garg , derkling@google.com, reijiw@google.com, Will Deacon , rientjes@google.com, "Kalyazin, Nikita" , patrick.roy@linux.dev, "Itazuri, Takahiro" , Andy Lutomirski , David Kaplan , Thomas Gleixner , Yosry Ahmed References: <20260320-page_alloc-unmapped-v2-0-28bf1bd54f41@google.com> <20260320-page_alloc-unmapped-v2-13-28bf1bd54f41@google.com> From: "Vlastimil Babka (SUSE)" In-Reply-To: <20260320-page_alloc-unmapped-v2-13-28bf1bd54f41@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/20/26 19:23, Brendan Jackman wrote: > A later patch will complicate the definition of these masks, this is a > preparatory patch to make that patch easier to review. > > - More masks will be needed, so add a PAGEBLOCK_ prefix to the names > to avoid polluting the "global namespace" too much. > > - This makes MIGRATETYPE_AND_ISO_MASK start to look pretty long. Well, > that global mask only exists for quite a specific purpose so just drop > it and take advantage of the newly-defined PAGEBLOCK_ISO_MASK. > > Signed-off-by: Brendan Jackman LGTM. Could be also part of the immediate cleanup series? Reviewed-by: Vlastimil Babka (SUSE)