From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Arnd Bergmann <arnd@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Moudy Ho <moudy.ho@mediatek.com>,
Ping-Hsun Wu <ping-hsun.wu@mediatek.com>,
daoyuan huang <daoyuan.huang@mediatek.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] media: platform: mtk-mdp3: fix Kconfig dependencies
Date: Wed, 21 Dec 2022 11:38:29 +0100 [thread overview]
Message-ID: <9e2d13f2-03cc-1c4c-d24d-b653aae81936@collabora.com> (raw)
In-Reply-To: <20221215164021.694343-1-arnd@kernel.org>
Il 15/12/22 17:40, Arnd Bergmann ha scritto:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The new mdp3 driver uses 'select' to force-enable a couple of drivers
> it depends on. This is error-prone and likely to cause dependency
> loops as well as warnings like:
>
> WARNING: unmet direct dependencies detected for VIDEO_MEDIATEK_VPU
> Depends on [n]: MEDIA_SUPPORT [=m] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_MEM2MEM_DRIVERS [=n] && VIDEO_DEV [=m] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=y])
> Selected by [m]:
> - VIDEO_MEDIATEK_MDP3 [=m] && MEDIA_SUPPORT [=m] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && (MTK_IOMMU [=m] || COMPILE_TEST [=y]) && VIDEO_DEV [=m] && (ARCH_MEDIATEK [=y] || COMPILE_TEST [=y]) && HAS_DMA [=y] && REMOTEPROC [=y]
>
> This specific warning was already addressed in a previous patch,
> but there are similar unnecessary 'select' statements, so turn those
> into 'depends on'. This also means the dependency on ARCH_MEDIATEK
> is redundant and can be dropped.
>
> Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
> Fixes: 9195a860ef0a ("media: platform: mtk-mdp3: remove unused VIDEO_MEDIATEK_VPU config")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
prev parent reply other threads:[~2022-12-21 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 16:40 [PATCH] media: platform: mtk-mdp3: fix Kconfig dependencies Arnd Bergmann
2022-12-21 10:38 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e2d13f2-03cc-1c4c-d24d-b653aae81936@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=daoyuan.huang@mediatek.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=moudy.ho@mediatek.com \
--cc=ping-hsun.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox