From: David Laight <David.Laight@ACULAB.COM>
To: 'Philipp Hortmann' <philipp.g.hortmann@gmail.com>,
Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-staging@lists.linux.dev" <linux-staging@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 2/2] staging: vt6655: Replace VNSvInPortB with ioread8
Date: Tue, 19 Apr 2022 08:57:59 +0000 [thread overview]
Message-ID: <9e33e133c7fd44258d89210d17c9fac2@AcuMS.aculab.com> (raw)
In-Reply-To: <fd71797d9d55d53f95c5c4e2df826bf85dd4626a.1650094595.git.philipp.g.hortmann@gmail.com>
From: Philipp Hortmann
> Sent: 16 April 2022 09:01
>
> Replace macro VNSvInPortB with ioread8. Avoid cast of the return
> value is possible with one exception.
Unless the hardware might be using PCI io space (which I doubt)
shouldn't it be using readb() not ioread8() ?
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
prev parent reply other threads:[~2022-04-19 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-16 8:00 [PATCH 0/2] staging: vt6655: Replace macro VNSvInPortB with ioread8() Philipp Hortmann
2022-04-16 8:00 ` [PATCH 1/2] staging: vt6655: Replace MACvGPIOIn with VNSvInPortB Philipp Hortmann
2022-04-16 8:00 ` [PATCH 2/2] staging: vt6655: Replace VNSvInPortB with ioread8 Philipp Hortmann
2022-04-19 8:57 ` David Laight [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e33e133c7fd44258d89210d17c9fac2@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox