From: Jon Smirl <jonsmirl@gmail.com>
To: lkml <linux-kernel@vger.kernel.org>, Jaroslav Kysela <perex@suse.cz>
Subject: Intel ICH - sound/pci/intel8x0.c
Date: Sat, 4 Sep 2004 22:43:01 -0400 [thread overview]
Message-ID: <9e4733910409041943490b9587@mail.gmail.com> (raw)
The joystick PCI ID table in intel8x0.c is not correct. Joysticks and
MIDI ports are ISA devices and need be located by manual probing. This
ID table needs to be removed. Joystick and MIDI ports do not have PCI
IDs.
The PCI IDs in this table are for the ISA bridge chips, not the
joystick port. These PC IDs should belong to the PCI bus driver. If I
fix the PCI bus driver to claim these like it should, joystick support
won't work any more.
static struct pci_device_id snd_intel8x0_joystick_ids[] = {
{ 0x8086, 0x2410, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* 82801AA */
{ 0x8086, 0x2420, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* 82901AB */
{ 0x8086, 0x2440, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* ICH2 */
{ 0x8086, 0x244c, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* ICH2M */
{ 0x8086, 0x248c, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* ICH3 */
// { 0x8086, 0x7195, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* 440MX */
// { 0x1039, 0x7012, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* SI7012 */
{ 0x10de, 0x01b2, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* NFORCE */
{ 0x10de, 0x006b, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* NFORCE2 */
{ 0x10de, 0x00db, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0 }, /* NFORCE3 */
{ 0, }
};
2410 82801AA ISA Bridge (LPC)
2420 82801AB ISA Bridge (LPC)
2440 82801BA ISA Bridge (LPC)
244c 82801BAM ISA Bridge (LPC)
248c 82801CAM ISA Bridge (LPC)
01b2 nForce ISA Bridge
--
Jon Smirl
jonsmirl@gmail.com
next reply other threads:[~2004-09-05 2:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-05 2:43 Jon Smirl [this message]
2004-09-05 11:55 ` Intel ICH - sound/pci/intel8x0.c Alan Cox
2004-09-05 15:26 ` Jon Smirl
2004-09-06 10:57 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2004-09-05 18:48 Matthieu Castet
2004-09-05 21:24 ` Jon Smirl
2004-09-05 20:49 ` Alan Cox
2004-09-06 2:09 ` Randy.Dunlap
2004-09-06 4:07 ` Jon Smirl
2004-09-06 2:13 ` Jon Smirl
2004-09-06 8:31 Matthieu Castet
2004-09-06 11:27 ` Alan Cox
2004-09-06 14:11 ` Jon Smirl
2004-09-06 8:40 Matthieu Castet
2004-09-06 15:48 Matthieu Castet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e4733910409041943490b9587@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox