From: Jon Smirl <jonsmirl@gmail.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Dave Airlie <airlied@linux.ie>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
DRI Devel <dri-devel@lists.sourceforge.net>,
Andrew Morton <akpm@osdl.org>,
Evan Paul Fletcher <evanpaul@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] DRM: add missing pci_enable_device()
Date: Wed, 15 Sep 2004 11:35:16 -0400 [thread overview]
Message-ID: <9e47339104091508354280713c@mail.gmail.com> (raw)
In-Reply-To: <1095250966.19930.25.camel@localhost.localdomain>
On Wed, 15 Sep 2004 13:22:48 +0100, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> On Mer, 2004-09-15 at 00:41, Jon Smirl wrote:
> > pci_enable/disable_device are correct in the dyn-minor patch. They
> > also appear to correct in the currently checked in DRM cvs. If fbdev
> > is loaded DRM does not do pci_enable/disable_device. It is assumed
> > that these calls are handled by the fbdev device.
>
> If you are calling pci_disable_device at all in the fb driver or DRI
> driver it is wrong, always wrong, always will be wrong for the main
> head. The video device is almost unique in that when you unload all
> the video drivers vgacon still owns and is using it. On some devices
> that needs PCI master enabled because of internal magic (like
> rendering text modes from the bios via SMM traps)
>
How do I trigger this mode on a card supported by DRM so that we can test it?
--
Jon Smirl
jonsmirl@gmail.com
next prev parent reply other threads:[~2004-09-15 15:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200409131651.05059.bjorn.helgaas@hp.com>
2004-09-13 23:28 ` [PATCH] DRM: add missing pci_enable_device() Dave Airlie
2004-09-14 14:45 ` Bjorn Helgaas
2004-09-14 23:12 ` Dave Airlie
2004-09-14 23:27 ` Bjorn Helgaas
2004-09-14 23:41 ` Jon Smirl
2004-09-15 12:22 ` Alan Cox
2004-09-15 15:35 ` Jon Smirl [this message]
2004-09-15 17:07 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e47339104091508354280713c@mail.gmail.com \
--to=jonsmirl@gmail.com \
--cc=airlied@linux.ie \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bjorn.helgaas@hp.com \
--cc=dri-devel@lists.sourceforge.net \
--cc=evanpaul@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox