Re: [PATCH] quiet non-x86 option ROM warnings

Jesse Barnes
2005-02-16T00:45:48Z

On Tuesday, February 15, 2005 4:36 pm, Jon Smirl wrote:
> You're removing the check for 55AA at the start of the ROM.

No, the check is still there, I just removed the printk if 0xaa55 isn't found
(my box returns 0x303 instead).

> I though
> the PCI standard was that all ROMs had to start with the no matter
> what object code they contain. Then if you look for PCIR there is a
> field in the stucture that says what language the ROM is in. Maybe the
> problem is in the BIOS_IN16() function and things are getting byte
> swapped wrong.

I thought the signature described what type of ROM was there? E.g. 0xaa55
means x86 ROM, x0303 means OF ROM, etc.?

At any rate, not having a ROM at all (which my case may be) isn't an error
either, so I think removing the printk is appropriate regardless.

Thanks,
Jesse