Re: [PATCH] quiet non-x86 option ROM warnings

Jesse Barnes
2005-02-17T17:31:03Z

On Thursday, February 17, 2005 8:33 am, Jon Smirl wrote:
> > No, pci_map_rom shouldn't test the signature IMHO. While PCI ROMs should
> > have the signature to be recognized as containing valid firmware images
> > on x86 BIOSes an OF, it's just a convention on these platforms, and I
> > would rather let people put whatever they want in those ROMs and still
> > let them map it...
>
> pci_map_rom will return a pointer to any ROM it finds. It the
> signature is invalid the size returned will be zero. Is this ok or do
> we want it to do something different?

Shouldn't it return NULL if the signature is invalid?

Jesse