Re: [PATCH] quiet non-x86 option ROM warnings

Jesse Barnes
2005-02-16T23:54:38Z

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

On Tuesday, February 15, 2005 5:03 pm, Benjamin Herrenschmidt wrote:
> What about printing "No PCI ROM detected" ? I like having that info when
> getting user reports, but I agree that a less worrying message would
> be good.

Ok, how about this then? It changes the printks in both drivers to KERN_INFO
and describes the situation a bit more accurately.

Signed-off-by: Jesse Barnes <jbarnes@sgi.com>

Thanks,
Jesse

P.S. Jon, I think the pci_map_rom code is buggy--if the option ROM signature
is missing or indicates that there's no ROM, the routine still returns a
valid pointer making the caller thing it succeeded. If we fix that up we can
fix up the callers.

[-- Attachment #2: aty-no-rom-present-cleanup.patch --]
[-- Type: text/x-diff, Size: 1089 bytes --]

===== drivers/video/aty/radeon_base.c 1.39 vs edited =====
--- 1.39/drivers/video/aty/radeon_base.c 2005-02-10 22:57:44 -08:00
+++ edited/drivers/video/aty/radeon_base.c 2005-02-16 15:48:48 -08:00
@@ -330,8 +330,8 @@

/* Very simple test to make sure it appeared */
if (BIOS_IN16(0) != 0xaa55) {
- printk(KERN_ERR "radeonfb (%s): Invalid ROM signature %x should be"
- "0xaa55\n", pci_name(rinfo->pdev), BIOS_IN16(0));
+ printk(KERN_INFO "radeonfb (%s): no ROM present\n",
+ pci_name(rinfo->pdev));
goto failed;
}
/* Look for the PCI data to check the ROM type */
===== drivers/video/aty/aty128fb.c 1.56 vs edited =====
--- 1.56/drivers/video/aty/aty128fb.c 2005-02-10 22:57:44 -08:00
+++ edited/drivers/video/aty/aty128fb.c 2005-02-16 15:50:12 -08:00
@@ -813,8 +813,8 @@

/* Very simple test to make sure it appeared */
if (BIOS_IN16(0) != 0xaa55) {
- printk(KERN_ERR "aty128fb: Invalid ROM signature %x should be 0xaa55\n",
- BIOS_IN16(0));
+ printk(KERN_INFO "aty128fb (%s): no ROM present\n",
+ pci_name(dev));
goto failed;
}