Re: Fwd: hpet patches

[Jon Smirl <jonsmirl@gmail.com>]

On 6/14/05, Bob Picco <bob.picco@hp.com> wrote:
> Jon,
> Jon Smirl wrote:        [Tue Jun 14 2005, 12:26:41PM EDT]
> > Apparently there are many Dell systems that have an HPET but Dell is
> > not providing the ACPI entry. Can we add some probing for the HPET or
> > use something like the ICH5 PCI ID to enable it?
> This is also true of HP x86 and x86_64 (AMD 8000 chipset) hardware.  I enabled
> it on my HP x86_64 with the appropriate PCI commands but it has been a while
> and can't recall the details.  This solution is good for platform specific
> configuration but of course doesn't enable the driver discovery to work.
> 
> I also verified that the Documentation/hpet.txt sample program worked. I can't
> remember who (SuSE ?) posted the x86_64 HPET stuff just before I
> finished.  So I never posted. I didn't feel great about the solution because
> the address was hardcoded. I found myself more irritated at HP for not having
> configured it in the BIOS and ACPI table.
> >
> > I have verified that all Dimension 8300, PE400, Precision 360 have
> > this problem. From what I can tell many other Dell models are also
> > missing HPET ACPI. The problem is not universal, there are a few Dell
> > models that do have the ACPI entry.
> 
> bob
> 

Problem like this are usually fixed with quirks:

DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL,   
PCI_DEVICE_ID_INTEL_82801EB_0,  quirk_intel_ich5_hpet);

quirk_intel_ich5_hpet()
{
    if (!hpet_address)
          hpet_address = 0xfed00000ULL;
}

0xfed00000ULL is right for ICH5, do you want to start adding these as
part of HPET support? My hpet works fine once the address is set. For
complete coverage you need a list of these for all of the AMD/Intel
chipsets with hpet support. The list isn't very big.

-- 
Jon Smirl
jonsmirl@gmail.com