From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261543AbVGZA2Q (ORCPT ); Mon, 25 Jul 2005 20:28:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261572AbVGZA2Q (ORCPT ); Mon, 25 Jul 2005 20:28:16 -0400 Received: from wproxy.gmail.com ([64.233.184.204]:25774 "EHLO wproxy.gmail.com") by vger.kernel.org with ESMTP id S261543AbVGZA2O convert rfc822-to-8bit (ORCPT ); Mon, 25 Jul 2005 20:28:14 -0400 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=Dqm2cfEkAmjKM8wnk+uuM8LIP/pizQdQwx6Rcvd6wpszyF5zhnZlLXl4B3vxc8d87F+CMMya4pEHofUorvBchlUmEhNJnL8RRi38hlF0hyvoniIQyg1NnkgVqKrgTPp4aqo44aYg8YH97TV529266RzhZTA7/dS7jqajcFe1IWI= Message-ID: <9e473391050725172833617aca@mail.gmail.com> Date: Mon, 25 Jul 2005 20:28:10 -0400 From: Jon Smirl Reply-To: Jon Smirl To: Greg KH Subject: Re: [PATCH] driver core: Add the ability to unbind drivers to devices from userspace Cc: dtor_core@ameritech.net, linux-kernel@vger.kernel.org In-Reply-To: <20050726000024.GA23858@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Content-Disposition: inline References: <9e47339105072421095af5d37a@mail.gmail.com> <200507242358.12597.dtor_core@ameritech.net> <9e4733910507250728a7882d4@mail.gmail.com> <9e47339105072509307386818b@mail.gmail.com> <20050726000024.GA23858@kroah.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On 7/25/05, Greg KH wrote: > On Mon, Jul 25, 2005 at 12:30:43PM -0400, Jon Smirl wrote: > > On 7/25/05, Dmitry Torokhov wrote: > > > On 7/25/05, Jon Smirl wrote: > > > > On 7/25/05, Dmitry Torokhov wrote: > > > > > On Sunday 24 July 2005 23:09, Jon Smirl wrote: > > > > > > I just pulled from GIT to test bind/unbind. I couldn't get it to work; > > > > > > it isn't taking into account the CR on the end of the input value of > > > > > > the sysfs attribute. This patch will fix it but I'm sure there is a > > > > > > cleaner solution. > > > > > > > > > > > > > > > > "echo -n" should take care of this problem I think. > > > > > > > > That will work around it but I think we should fix it. Changing to > > > > strncmp() fixes most cases. > > > > > > > > - if (strcmp(name, dev->bus_id) == 0) > > > > + if (strncmp(name, dev->bus_id, strlen(dev->bus_id)) == 0) > > > > > > > > > > This will produce "interesting results" if you have both "blah-1" and > > > "blah-10" devices on the bus. > > Yes, not a good thing for USB devices specifically. > > > Then the better solution is to fix the generic attribute set code to > > strip leading and trailing white space. > > No, that might break other things as we have not been doing this from > day one. I'd rather just change these two places, if it's that big of a > deal. It was documented (in a lwn.net article) and the changelog entry, > that you should use "echo -n". I didn't realize that echo was adding the CR, I thought that it always appeared on the end of a sysfs attribute set. So now I have to go add white space stripping to a dozen fbdev/drm sysfs attribute implementations. Given that the param is const I may have to allocate new buffers and copy. I also wonder how many other people have made the same mistake. Are you sure it would break other things? These are supposed to be text attributes, not binary ones. -- Jon Smirl jonsmirl@gmail.com