Re: [PATCH] fbdev: colormap fixes

Geert Uytterhoeven
2005-07-28T16:02:46Z

On Thu, 28 Jul 2005, Jon Smirl wrote:
> Can you review this fix for the issues below? I fixed things to
> automatically adjust the number of entries to whatever fits in
> PAGE_SIZE.

Looks OK, but...

> @@ -317,18 +317,18 @@ static ssize_t show_cmap(struct class_de
> !fb_info->cmap.green)
> return -EINVAL;
>
> - if (PAGE_SIZE < 4096)
> + if (fb_info->cmap.len > PAGE_SIZE / 16)
> return -EINVAL;

... perhaps you want to just return the first PAGE_SIZE/16 entries, instead of
failing?

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds