Re: [PATCH] fbdev: colormap fixes

Geert Uytterhoeven
2005-07-28T13:43:02Z

On Thu, 28 Jul 2005, Jon Smirl wrote:
> On 7/28/05, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Wed, 27 Jul 2005, Linux Kernel Mailing List wrote:
>
> There are a couple of ways to fix this.
>
> 1) Add a check to limit use of the sysfs attributes to 256 entries. If
> you want more you have to use /dev/fb0 and the ioctl. More is an
> uncommon case.
> 2) Switch this to a binary parameter. Now you have to use tools like
> hexdump instead of cat to work with the data. It was nice to be able
> to use cat to see the current map.
>
> Does anyone have preferences for which way to fix it?

I prefer the first way.

> Thanks for catching the problems. I'm posting these patches to fbdev
> for review first so it is best to catch bugs there.

Sorry, sometimes I miss a few things...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds