Re: [PATCH] driver core: Add the ability to unbind drivers to devices from userspace

Pavel Machek
2005-08-07T18:54:53Z

Hi!

> > > > Could you tell me why you don't just fail the operation if malformed
> > > > input is supplied?
> > >
> > > Leading/trailing white space should be allowed. For example echo
> > > appends '\n' unless you know to use -n. It is easier to fix the kernel
> > > than to teach everyone to use -n.
> >
> > Please, NO! echo -n is the right thing to do, and users will eventually learn.
> > We are not going to add such workarounds all over the kernel...
>
> It is not a work around. These are text attributes meant for human
> use. Humans have a hard time cleaning up things they can't see. And
> the failure mode for this is awful, your attribute won't set but
> everything on the screen looks fine.

Kernel is not a place to be user friendly. Or do you propose stripping whitespace
for open(), too? File called "foo.txt " certainly *is* going to be confusing, but it should be allowed at kernel level.

Now... echo foo > /sys/var does not properly report errors. Thats bad, but it needs to
be fixed in bash.
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms