Re: [PATCH] driver core: Add the ability to unbind drivers to devices from userspace

Jon Smirl
2005-07-25T14:28:35Z

On 7/25/05, Dmitry Torokhov <dtor_core@ameritech.net> wrote:
> On Sunday 24 July 2005 23:09, Jon Smirl wrote:
> > I just pulled from GIT to test bind/unbind. I couldn't get it to work;
> > it isn't taking into account the CR on the end of the input value of
> > the sysfs attribute. This patch will fix it but I'm sure there is a
> > cleaner solution.
> >
>
> "echo -n" should take care of this problem I think.

That will work around it but I think we should fix it. Changing to
strncmp() fixes most cases.

- if (strcmp(name, dev->bus_id) == 0)
+ if (strncmp(name, dev->bus_id, strlen(dev->bus_id)) == 0)

I work in this area and I couldn't figure out why it was silently not
working. I had to add the printk to the source before I could figure
it out. I suspect most people are going to have this trouble.

This has also made me realize that I have created other places in the
kernel where my sysfs attribute code is not going to work correctly.
Maybe we should adjust the sysfs driver to strip leading and trailing
white space before passing the string on.

--
Jon Smirl
jonsmirl@gmail.com