Re: [PATCH] driver core: Add the ability to unbind drivers to devices from userspace

Mitchell Blank Jr
2005-07-28T07:01:26Z

Greg KH wrote:
> > + /* locate trailng white space */
> > + z = y = x;
> > + while (y - buffer->page < count) {
> > + y++;
> > + z = y;
> > + while (isspace(*y) && (y - buffer->page < count)) {
> > + y++;
> > + }
> > + }
> > + count = z - x;
>
> Hm, I _think_ this works, but I need someone else to verify this...
> Anyone else?

It looks sane-ish to me, but also more complicated than need be. Why can't
you just do something like:

while (count > 0 && isspace(x[count - 1]))
count--;

-Mitch