public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Igor Prusov <ivprusov@salutedevices.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: prusovigor@gmail.com, kernel@salutedevices.com,
	linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: Add bindings for Everest ES7243E
Date: Wed, 10 Jul 2024 12:35:43 +0200	[thread overview]
Message-ID: <9e49c726-9cc9-46ac-a9dc-9e2debbc90b7@kernel.org> (raw)
In-Reply-To: <20240709104117.33431-2-ivprusov@salutedevices.com>

On 09/07/2024 12:41, Igor Prusov wrote:
> Add dt-bindings for Everest Semi ES7243E ADC.
> 
> Signed-off-by: Igor Prusov <ivprusov@salutedevices.com>
> ---


> +required:
> +  - compatible
> +  - reg
> +  - "#sound-dai-cells"
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +      es7243e: es7243e@14 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
usually audio-codec

Best regards,
Krzysztof


  reply	other threads:[~2024-07-10 10:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-09 10:41 [PATCH 0/2] Add ES7243E ADC driver Igor Prusov
2024-07-09 10:41 ` [PATCH 1/2] ASoC: dt-bindings: Add bindings for Everest ES7243E Igor Prusov
2024-07-10 10:35   ` Krzysztof Kozlowski [this message]
2024-07-09 10:41 ` [PATCH 2/2] ASoC: codecs: add ES7243E ADC driver Igor Prusov
2024-07-10 10:34   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e49c726-9cc9-46ac-a9dc-9e2debbc90b7@kernel.org \
    --to=krzk@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=ivprusov@salutedevices.com \
    --cc=kernel@salutedevices.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=prusovigor@gmail.com \
    --cc=robh@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox