Re: Re: [PATCH v5 2/2] usb: dwc3: eic7700: Add EIC7700 USB driver

Hang Cao
2025-11-05T12:28:12Z

Hi, Krzysztof and Thinh:
>
> > +
> > static int dwc3_generic_probe(struct platform_device *pdev)
> > {
> > const struct dwc3_properties *properties;
> > @@ -83,6 +119,12 @@ static int dwc3_generic_probe(struct platform_device *pdev)
> > else
> > probe_data.properties = DWC3_DEFAULT_PROPERTIES;
> >
> > + if (of_device_is_compatible(dev->of_node, "eswin,eic7700-dwc3")) {
>
> No, you have driver match data for that.
>
We implemented it with driver match data in v4 patch.
https://lore.kernel.org/all/20251016222713.d2sutc7tyf2idbkv@synopsys.com/

However, Thinh suggested using direct function calls instead, noting
that this is a function call rather than data.
We are not sure if we’ve fully understood his feedback correctly.

Our driver requires special handling for USB bus initialization, which does
involve function calls.

So we’d really appreciate it if you and Thinh could share further thoughts
on which approach would be more suitable for our driver’s needs.

Best regards,
Hang Cao