Re: [PATCH v2 1/1] arm64: dts: exynos990: Add clock management unit nodes

Krzysztof Kozlowski
2024-12-22T14:24:09Z

On 15/12/2024 18:08, Igor Belwon wrote:
> Add CMU nodes for:
> - cmu_top: provides clocks for other blocks
> - cmu_hsi0: provides clocks for usb31
>
> Signed-off-by: Igor Belwon <igor.belwon@mentallysanemainliners.org>
> ---
> arch/arm64/boot/dts/exynos/exynos990.dtsi | 28 +++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/exynos/exynos990.dtsi b/arch/arm64/boot/dts/exynos/exynos990.dtsi
> index 2619f821bc7c..d6a8c04e6602 100644
> --- a/arch/arm64/boot/dts/exynos/exynos990.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos990.dtsi
> @@ -5,6 +5,7 @@
> * Copyright (c) 2024, Igor Belwon <igor.belwon@mentallysanemainliners.org>
> */
>
> +#include <dt-bindings/clock/samsung,exynos990.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
>
> / {
> @@ -199,6 +200,24 @@ pinctrl_peric1: pinctrl@10730000 {
> interrupts = <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + cmu_hsi0: clock-controller@10a00000 {
> + compatible = "samsung,exynos990-cmu-hsi0";

Does it depend on anything? Cover letter is quiet here, but it should
explain any dependencies.

> + reg = <0x10a00000 0x8000>;
> + #clock-cells = <1>;
> +
> + clocks = <&oscclk>,
> + <&cmu_top CLK_DOUT_CMU_HSI0_BUS>,
> + <&cmu_top CLK_DOUT_CMU_HSI0_USB31DRD>,
> + <&cmu_top CLK_DOUT_CMU_HSI0_USBDP_DEBUG>,
> + <&cmu_top CLK_DOUT_CMU_HSI0_DPGTC>;
> + clock-names = "oscclk",
> + "bus",
> + "usb31drd",
> + "usbdp_debug",
> + "dpgtc";
> +

Not much improved. Still stray blank line.

> + };
Best regards,
Krzysztof